Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layered graph generator not connecting all generated nodes #22

Open
uber-mahyar2 opened this issue Mar 6, 2019 · 0 comments
Open
Labels
bug Something isn't working

Comments

@uber-mahyar2
Copy link
Contributor

We connect to lower layer modules at random, choosing a small subset of modules to depend on (something like 5 / 100). As a result, the more modules there are in a layered graph, the more likely there are modules that would not be be connected to the main app graph since the amount of lower level modules that are connected to by higher level modules stays constant at 5 modules.

As a result %10-%20 of modules in most graphs are not connected to the main graph. Modules not connected to the main graph are not built by most build systems, so it looks like the layered graph is inherently faster than a flat graph, while it's only compiling %10-%20 less code & modules than a flat graph.

@uber-mahyar2 uber-mahyar2 added the bug Something isn't working label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant