Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvidia toggle is confusing #223

Open
castrojo opened this issue Feb 22, 2024 · 1 comment
Open

Nvidia toggle is confusing #223

castrojo opened this issue Feb 22, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@castrojo
Copy link
Member

ujust toggle-nvk is confusing, you have to know what nvk is. And then on top of that it just rebases without asking, which might be a bit disconcerting. What do we think about renaming it toggle-nvidia and then showing the current state and what it wants to do like we do for devmode:

❯ ujust devmode
Developer mode is currently enabled
Enable or Disable developer mode

Enable
Disable

Something like:"

❯ ujust toggle-nvidia
Current nvidia driver: NVK (Open Source)
Enable or Disable Nvidia driver

Enable
Disable

For the status we could say:
NVK (Open Source/MESA)
Nvidia (From Nvidia Inc)

That way it's more clear what image I am on, and which image I am switching to?

@HikariKnight
Copy link
Member

im fine with renaming it, you can do that right away.
i can do the logic next week since i am busy this friday+weekend (unless anyone else wants to change it, as the logic has been used elsewhere in ujust)

@castrojo castrojo added the help wanted Extra attention is needed label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants