Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: set webapi token exp. to 15 min and refresh when 4 min left #2589

Merged
merged 7 commits into from
Aug 12, 2024
2 changes: 1 addition & 1 deletion gen3/test/bootstrapTest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test_bootstrap_fenceconfig() {
because $? "secret template exists and is valid yaml: $secretConf"
[[ -f "$publicConf" ]] && yq -r . < "$secretConf" > /dev/null;
because $? "public template exists and is valid yaml: $secretConf"
python3.8 "$GEN3_HOME/apis_configs/yaml_merge.py" "$publicConf" "$secretConf" | yq -r . > /dev/null;
python3.9 "$GEN3_HOME/apis_configs/yaml_merge.py" "$publicConf" "$secretConf" | yq -r . > /dev/null;
because $? "yaml_perge public private should yield valid yaml"
}

Expand Down
2 changes: 1 addition & 1 deletion gen3/test/fenceStuffTest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ EOM
C: 4
B: 3
EOM
json3="$(python3.8 "$GEN3_HOME/apis_configs/yaml_merge.py" "$yaml1" "$yaml2")"; because $? "yaml_merge should succeed"
json3="$(python3.9 "$GEN3_HOME/apis_configs/yaml_merge.py" "$yaml1" "$yaml2")"; because $? "yaml_merge should succeed"
[[ "1" == "$(jq -r .A <<<"$json3")" ]]; because $? ".A should be 1"
/bin/rm "$yaml1"
/bin/rm "$yaml2"
Expand Down
1 change: 1 addition & 0 deletions kube/services/ohdsi-atlas/ohdsi-atlas-config-local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ data:
configLocal.cohortComparisonResultsEnabled = false;
configLocal.userAuthenticationEnabled = true;
configLocal.plpResultsEnabled = false;
configLocal.refreshTokenThreshold = 1000 * 60 * 4; // refresh auth token if it will expire within 4 minutes
return configLocal;
});

Expand Down
2 changes: 1 addition & 1 deletion kube/services/ohdsi-webapi/ohdsi-webapi-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ stringData:

security_cors_enabled: "true"
security_origin: "*"
security_token_expiration: "43200"
security_token_expiration: "900"
security_ssl_enabled: "false"

security_provider: AtlasRegularSecurity
Expand Down
Loading