Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor function compileNewQuery of SybaseConnection class #22

Open
nunomazer opened this issue Oct 5, 2016 · 5 comments
Open

Refactor function compileNewQuery of SybaseConnection class #22

nunomazer opened this issue Oct 5, 2016 · 5 comments
Labels
Hacktoberfest

Comments

@nunomazer
Copy link
Contributor

Should use collections
@tzkmx
Copy link

tzkmx commented Oct 11, 2016

Do you have any tests for this class in order to being able to do the refactor without any functionality loss? At least some characterization tests?

@mainginski
Copy link
Collaborator

Formally not, but if you want I can list all the features of this class.

@tzkmx
Copy link

tzkmx commented Oct 15, 2016

It would be very usefull, I'd lke a lot to contribute to this refactoring. Thanks in advance.

@mainginski
Copy link
Collaborator

Ok, I can make this on Tuesday!

@mainginski
Copy link
Collaborator

Hello, as promised: https://github.com/uepg/laravel-sybase/wiki/For-contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nunomazer @tzkmx @mainginski