Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMO Algorithm Issues #60

Open
urinieto opened this issue Mar 7, 2017 · 3 comments
Open

VMO Algorithm Issues #60

urinieto opened this issue Mar 7, 2017 · 3 comments

Comments

@urinieto
Copy link
Owner

urinieto commented Mar 7, 2017

The new Variable Markov Oracle algorithm (included in this PR) didn't pass the unit tests because of two reasons:

  • The results of the main vmo call did not follow the expected format: len(my_bounds) == len(my_labels) + 1. To fix this, I simply removed the last label (since it seemed that it was always repeated). @wangsix, could you confirm this is correct?

  • When calling VMO to obtain the labels only (i.e., when we have used another algorithm to compute the boundaries), the previously computed boundaries were ignored. This was an MSAF problem, which I fixed by making sure we use the old boundaries in the interface. @WANGSIZ, do you think VMO could be improved by including previously computed boundaries to obtain the labels only? If not, the current labels synchronization to the previously computed boundaries should suffice.

@wangsix
Copy link
Contributor

wangsix commented Mar 8, 2017

Hey @urinieto, without deep investigation into my own codes, the first point seems fine. About the second one, I agree with you I should comply to the option of pre-defined boundaries. I will refine the interface to have that option.

@urinieto
Copy link
Owner Author

urinieto commented Mar 8, 2017

Sounds good. The current version in MSAF is stable, but looking forward to your potential improvements. Thanks!

@urinieto
Copy link
Owner Author

urinieto commented Jun 4, 2017

Hey Cheng-i, did you have a chance to look into this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants