Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for comments in AdminUI #148

Open
nzsb opened this issue Mar 18, 2019 · 5 comments
Open

Add support for comments in AdminUI #148

nzsb opened this issue Mar 18, 2019 · 5 comments

Comments

@nzsb
Copy link

nzsb commented Mar 18, 2019

Hi,

I have evaluated your project, it is really good work and we will use it in our project!

It would be great to have the possibility for a dedicated comment field also in Episerver AdminUI (I have a client who needs this). Currently as workaround we can only use a fake-language for this purpose, which is not really elegant solution.

Thanks in advance!

@valdisiljuconoks
Copy link
Owner

thanks for evaluation. interesting request. how would you expect to add comments? are those something that's coming from developer/code?

@nzsb
Copy link
Author

nzsb commented Mar 19, 2019

What I thought of is that it could be configurable to blend in as a comment column in AdminUI, so even the customer can view, add or change it, and it can be defined on resource-key-basis (so not for each language).
Personally I prefer to work with clean and obvious names, but in our case we have thousand of legacy resources and somebody would add comments for the non-obvious ones.
It could be also be used to document placeholders in resource texts, which will get replaced before displaying - such thing is very common and no way to figure those out from the name, somewhere it has to be documented.
So it could be also used basically for everything people the RESX tag using for.
I haven't thought of that, but defining the initial value through an attribute in code would be also a good idea.
Thanks for considering!

@valdisiljuconoks
Copy link
Owner

I'm hacking some ideas together as I write.. ;)

@nzsb
Copy link
Author

nzsb commented Mar 20, 2019

Already? You are amazingly fast :-)

@valdisiljuconoks
Copy link
Owner

due to time constraints, had to move to 6.0 version unfortunately

@valdisiljuconoks valdisiljuconoks modified the milestones: 6.0, 6.1 Feb 16, 2020
@valdisiljuconoks valdisiljuconoks modified the milestones: 6.1, 6.2 Jun 1, 2020
@valdisiljuconoks valdisiljuconoks removed this from the 6.2 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants