Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] benchmark over test framework #621

Open
artikell opened this issue Jun 10, 2024 · 0 comments
Open

[NEW] benchmark over test framework #621

artikell opened this issue Jun 10, 2024 · 0 comments

Comments

@artikell
Copy link
Contributor

artikell commented Jun 10, 2024

The problem/use-case that the feature addresses

When implementing the migration of unit tests for quicklists, #515 . It contains a lot of benchmark code in the middle. During this period, the time consumption was counted.

We often need to quantify the effects of optimization, such as memory and time consumption. And, there should be a unified set of performance reports on different hardware.

In this way, Valkey can have a performance report, specifically targeting critical logic, and can visually see the optimization results. And there is also a standard to describe the PR for subsequent optimization.

Description of the feature

We can implement a function type starting with "bench_", referring to the Golang benchmark, which supports the number of incoming loops, and defaults to counting the number of calls, related time consumption, and memory usage.
It also supports standard format output, such as CSV.

Alternatives you've considered

Rewrite some loops within the existing testing framework

Additional information

Any additional information that is relevant to the feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant