Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not working on pull_request event #2

Open
brenoalvs opened this issue Nov 6, 2020 · 4 comments
Open

It's not working on pull_request event #2

brenoalvs opened this issue Nov 6, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@brenoalvs
Copy link

Describe the bug
It retrieves an error when trying to push the POT file to the repository when running in the pull_request context.

To Reproduce
Steps to reproduce the behavior:

  1. Create a workflow file with the event pull_request
  2. Open a pull request to the desired branch and see the build fails.
name: Generate POT

on:
  pull_request:
    branches:
      - test-pr

jobs:
  i18n:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Generate POT file
      uses: varunsridharan/[email protected]
      with:
        save_path: './languages'
        item_slug: 'plugin-slug'
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expected behavior
The build should pass and with the new POT file generated and committed.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@varunsridharan varunsridharan self-assigned this Nov 6, 2020
@varunsridharan varunsridharan added the bug Something isn't working label Nov 6, 2020
@varunsridharan
Copy link
Owner

@brenoalvs thanks for informing.

I would like to know if you want to push the generated pot file to the open pull request or you want to generate the pot file once the pull request is merged ?

@brenoalvs
Copy link
Author

@varunsridharan Hm, I think that makes sense push on the PR branch.
If developers want to generate the POT file after merge they can use the push event instead which is triggered when a merge occurs.

@varunsridharan
Copy link
Owner

@brenoalvs so what I understood is that you want to trigger this action when a pull request is updated & push the generated pot file to the pull request branch ?

@brenoalvs
Copy link
Author

@varunsridharan Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants