Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Time Log Diagram #2

Open
vasu-gondaliya opened this issue Mar 15, 2021 · 12 comments
Open

Responsive Time Log Diagram #2

vasu-gondaliya opened this issue Mar 15, 2021 · 12 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@vasu-gondaliya
Copy link
Owner

Make the time log diagram to be responsive with screen size.
The arrows and tables need to be placed such a way that it remains same for all screens.

@vasu-gondaliya vasu-gondaliya added good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs labels Mar 15, 2021
@johnzarnowski
Copy link

Hi I have a project for a software methodology class to contribute to an open source repository and I'm interested in this project. Could you let me know if you're still interested in getting the issue solved and potentially be assigned to it?

@vasu-gondaliya
Copy link
Owner Author

Sorry I am not getting what said. Are you saying you want to solve this issue and I assign this issue to you?

@johnzarnowski
Copy link

Yes; I would love to work on the issue & would appreciate if you could assign it to me (sorry for the confusing phrasing)

@vasu-gondaliya
Copy link
Owner Author

Sure @johnzarnowski . Go for it. Ask for any help if you want.

@johnzarnowski
Copy link

@vasu-gondaliya I was able to add a horizontal scrollbar that appears when the window is changed to a size that is smaller than the width of the table. Is that what you were looking for?

@vasu-gondaliya
Copy link
Owner Author

I am talking about the animation with red arrows and tables below output table. Are you talking about the input table? Or this animation. If you have added the scroll bar for the input table then it's good. I will merge it but this issue is for that animation time log.

@johnzarnowski
Copy link

Hi @vasu-gondaliya I spent the weekend working on the issue & I couldn't figure out how to solve the issue. I did submit a pull request that added the horizontal scrollbar to the input table. I appreciate all of your help & wish you the best of luck in this & all of your other projects in the future!

@vasu-gondaliya
Copy link
Owner Author

Thank you for your efforts @johnzarnowski . Do you have any advice on how to solve this issue?

@johnzarnowski
Copy link

@vasu-gondaliya If you reference my pull request, you could try applying the same change that I made on the input table to the time log diagram

@vasu-gondaliya
Copy link
Owner Author

@johnzarnowski There is no pull request made.

@sr-04
Copy link

sr-04 commented Jul 10, 2023

issue resolved?

shubhamtalan996 added a commit to shubhamtalan996/cpu-scheduling-algorithms that referenced this issue Nov 23, 2023
shubhamtalan996 added a commit to shubhamtalan996/cpu-scheduling-algorithms that referenced this issue Nov 23, 2023
@shubhamtalan996
Copy link

shubhamtalan996 commented Nov 26, 2023

@vasu-gondaliya I have added a pull request for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

4 participants