Ensure is_sized in global layout lemma #1115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be useful for satisfying the precondition of `PointsToRaw::into_typed`, saving a `layout_for_type_is_valid`/`size_of`. Now users can write things like `global size_of int == 1` to make ghost/unsized types `is_sized`, but that's another topic. We may need to constraint the types that can use `global size_of`, but it's not a problem to ensure `is_sized` here. Anyhow, `assert(size_of::<int>() == 1)` is already a mistake.
ouuan
force-pushed
the
global-layout-sized
branch
from
11eb941
to
a11ffee
Compare
I just realized that incorrect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful for satisfying the precondition of
PointsToRaw::into_typed, saving alayout_for_type_is_valid/size_of.Now users can write things like
global size_of int == 1to make ghost/unsized typesis_sized, but that's another topic. We may need to constraint the types that can useglobal size_of, but it's not a problem to ensureis_sizedhere. Anyhow,assert(size_of::<int>() == 1)is already a mistake.