Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jshint? #40

Open
Gpeschke opened this issue Nov 7, 2019 · 5 comments
Open

Jshint? #40

Gpeschke opened this issue Nov 7, 2019 · 5 comments
Assignees
Projects
Milestone

Comments

@Gpeschke
Copy link

Gpeschke commented Nov 7, 2019

I know it's probably a lot to ask, but it'd be SUPER cool if we could integrate jshint- running it on the javascript code before eval, then if the code errors, spitting out what jshint found.

@videlais videlais self-assigned this Nov 27, 2019
@videlais
Copy link
Owner

That would probably mean including jshint in the build itself, which would be a major addition for what seems like a smaller number of use cases.

@Gpeschke
Copy link
Author

Gpeschke commented Feb 7, 2020

To clarify- I was meaning before eval, not before eval().
Linting is similar to syntax highlighting in the dev cycle.
Jshint is javascript's linting tool.

@videlais videlais added this to To do in 2.1 Feb 9, 2020
@videlais videlais added this to the 2.1 milestone Feb 9, 2020
videlais pushed a commit that referenced this issue Feb 9, 2020
Enforcement of ESLint "Standard" ruleset with the exception of "semi" set to ["error", "always"].
@videlais
Copy link
Owner

videlais commented Feb 9, 2020

@Gpeschke Strict enforcement of ESLint "Standard" is now part of the GitHub action workflow.

@Gpeschke
Copy link
Author

Hmmm... still seems like we are talking bout separate things.

I'm talking about within twine, when you are developing a story, it'd be nice to be able to lint.

@videlais
Copy link
Owner

@Gpeschke: We were originally talking about the same thing, I think. For you to be able to lint in the editor, either Twine 2 would have to add it (which it probably won't) or Snowman would have to carry and maintain the functionality (which is a huge hassle for little gain).

I'd like to eventually be able to add #20 at some point, but linting seems a long way off unless Twine 2 adds it for editing Story JavaScript.

If you want linting in your code, I'd recommend using something like TweeGo or my own Extwee and working on JavaScript outside of the browser or application. Linting could easily be part of the compiling process through ESLint or other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.1
  
To do
Development

No branches or pull requests

2 participants