Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump virtual kubelet dependency version #8

Open
Jeffwan opened this issue Jan 22, 2021 · 2 comments
Open

Bump virtual kubelet dependency version #8

Jeffwan opened this issue Jan 22, 2021 · 2 comments

Comments

@Jeffwan
Copy link
Contributor

Jeffwan commented Jan 22, 2021

github.com/virtual-kubelet/virtual-kubelet v0.10.0

is being used in this project. VK just release v1.4.0 this week, there're lots of changes including the first major release v1.0 and some more features and bug fixes to catch up.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 27, 2021

changes highlights

v0.11.0 Add ConfigureNode method and remove previous changes. add go mod. k8s deps 1.13.x
v1.0.0 nothing
v1.1.0 k8s 1.15
v1.2.0 nothing
v1.3.0 k8s 1.18
v1.4.0 v1 leases instead of v1beta1. Add v2 node provider implementation

Provider interface has not been changed for long time.

type Provider interface {
	node.PodLifecycleHandler

	// GetContainerLogs retrieves the logs of a container by name from the provider.
	GetContainerLogs(ctx context.Context, namespace, podName, containerName string, opts api.ContainerLogOpts) (io.ReadCloser, error)

	// RunInContainer executes a command in a container in the pod, copying data
	// between in/out/err and the container's stdin/stdout/stderr.
	RunInContainer(ctx context.Context, namespace, podName, containerName string, cmd []string, attach api.AttachIO) error

	// ConfigureNode enables a provider to configure the node object that
	// will be used for Kubernetes.
	ConfigureNode(context.Context, *v1.Node)
}

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 27, 2021

Based on these information, I think for fargate provider, we should have a version on 1.13 first and then move to 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant