Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Galleries not showing in VS Code jupyter environment #336

Open
dnth opened this issue Jun 27, 2024 · 0 comments
Open

[Bug]: Galleries not showing in VS Code jupyter environment #336

dnth opened this issue Jun 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dnth
Copy link
Collaborator

dnth commented Jun 27, 2024

What happened?

I tried to display the galleries in VS Code Jupyter environment and nothing is shown.

What did you expect to see?

A fastdup HTML gallery.

To solve this issue we could simply replace this line

if 'JPY_PARENT_PID' in os.environ:

with

if 'JPY_PARENT_PID' in os.environ or get_ipython().__class__.__name__ == 'ZMQInteractiveShell':

I can open a PR if it's necessary.

What version of fastdup were you runnning on?

2.5

What version of Python were you running on?

Python 3.10

Operating System

Ubuntu 22.04

Reproduction steps

No response

Relevant log output

No response

Attach a screenshot [Optional]

No response

Contact Details [Optional]

No response

@dnth dnth added the bug Something isn't working label Jun 27, 2024
@dnth dnth self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant