Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why require 0.19.6, and then replace it with 0.18.3? #5

Open
k82cn opened this issue Mar 15, 2021 · 7 comments
Open

Why require 0.19.6, and then replace it with 0.18.3? #5

k82cn opened this issue Mar 15, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@k82cn
Copy link
Member

k82cn commented Mar 15, 2021

rt

@k82cn k82cn added the bug Something isn't working label Mar 15, 2021
@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 16, 2021

Sorry for the mistake. Let me fix it.

@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 16, 2021

fixed: #8

@k82cn
Copy link
Member Author

k82cn commented Mar 16, 2021

hm... why do we dependent k8s? If so, how can us support different versino of k8s for different community?

@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 17, 2021

hm... why do we dependent k8s? If so, how can us support different versino of k8s for different community?

Becase the type.go and register.go depends on the libraries under k8s.io. I'll provide a script for users to update the version in go.mod automatically and they can generate the clients by another script under hack/

@k82cn
Copy link
Member Author

k82cn commented Mar 17, 2021

hm... why do we dependent k8s? If so, how can us support different versino of k8s for different community?

Becase the type.go and register.go depends on the libraries under k8s.io. I'll provide a script for users to update the version in go.mod automatically and they can generate the clients by another script under hack/

Can we just keep volcano-sh/apis? and let user to manage go.mod :)

@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 18, 2021

hm... why do we dependent k8s? If so, how can us support different versino of k8s for different community?

Becase the type.go and register.go depends on the libraries under k8s.io. I'll provide a script for users to update the version in go.mod automatically and they can generate the clients by another script under hack/

Can we just keep volcano-sh/apis? and let user to manage go.mod :)

We've written the logic about how to generate the CRDS and they must depend on the libraries under k8s.io. So these libraries are necessary. Of course, we can let user to manage go.mod.

@k82cn
Copy link
Member Author

k82cn commented Mar 26, 2022

if so, it's not necessary to have such a repo :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants