Add acceptance test

[smortex]

We have an example in this project and can run acceptance tests against it. Will it work?

[smortex]

With no experience with this module, fixing acceptance tests might be tricky… I feel like somebody used to the module can quickly manage to fix these tests so that we can have more coverage during tests. @FlorentPoinsaut maybe wink wink wink 😉 ?

The idea would be to adjust examples/init.pp until it works on all supported OS…

[FlorentPoinsaut]

I take a look.

[FlorentPoinsaut]

There are a problem with dependency packages (*_package_name) set in param class.
For Bareos 18.2 and 19.2, it need *-python-plugin package but for 20 and 21 versions, it is *-python3-plugin.
I don't find a way to do this without moving this variables form param class to repository class.
May I do that or you see another solution?

[smortex]

Okay, if I follow correctly the package lists are OS dependent and dependent on the usage of external repos. Maybe me can have for each OS the list of packages by repo in params.pp, e.g.:

$system_director_packages = ['foo']
$bareos_director_packages = ['python2-foo']

And for another OS:

$system_director_packages = ['python-foo']
$bareos_director_packages = ['python3-foo']

Then depending on the repo used we use the suited variable in the main manifest:

class bareos (
  # ...
  $director_package_name = undef, # change to undef so we can pick later
) inherits bareos::params {

  # Get the right packages for fallback if not provided
  $default_director_packages = $manage_repo ? {
    true  => $bareos_director_packages,
    false => $system_director_packages,
  }

  # pick the right package
  $director_packages = pick($director_package_name, $default_director_packages)

  # use it
  package { $director_packages:
    # ...
  }
}

That way we don't change the interface for end users of the module and all the actual data is in params.pp (making it easy to switch to hiera data in the future).

Probably not the only way to do it?

[jhoblitt]

Rebased on current master.

[jhoblitt]

It looks like this is failing because the bareos-database-mysql doesn't exist for baseos 21: https://www.bareos.com/end-of-life-mysql/

[jhoblitt]

Rebased on current master.