FPM global_pool_settings are not applied to the default pool

[mpdude]

At least with version 6.0.2 of this module, the global_pool_settings parameter in php::fpm was applied to the default www pool. This is no longer the case in v8.0.2, but it is not mentioned as a breaking change in the CHANGELOG either.

I suspect the change in #572 caused this:

The default pool is now defined in params.pp:

puppet-php/manifests/params.pp

Lines 17 to 30 in 82a1698

	$fpm_pools = {
	'www' => {
	'catch_workers_output' => 'no',
	'listen' => '127.0.0.1:9000',
	'listen_backlog' => -1,
	'pm' => 'dynamic',
	'pm_max_children' => 50,
	'pm_max_requests' => 0,
	'pm_max_spare_servers' => 35,
	'pm_min_spare_servers' => 5,
	'pm_start_servers' => 5,
	'request_terminate_timeout' => 0,
	},
	}

fpm.pp uses a create_resources call. This function will only use default values from the third argument (the global_pool_settings) when they are not already specified in the second argument's hash.

puppet-php/manifests/fpm.pp

Line 116 in 82a1698

create_resources(::php::fpm::pool, $real_pools, $real_global_pool_settings)