Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: update SFUI to version 0.12.0 #178

Open
1 task done
Baroshem opened this issue Feb 25, 2022 · 5 comments
Open
1 task done

[Feature]: update SFUI to version 0.12.0 #178

Baroshem opened this issue Feb 25, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request hackathon
Milestone

Comments

@Baroshem
Copy link
Collaborator

How the project can be improved?

update SFUI to version 0.12.0

What are the acceptance criteria?

  • [ ]

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Baroshem Baroshem added enhancement New feature or request hackathon labels Feb 25, 2022
@Baroshem Baroshem added this to the 1.2.0 milestone Feb 25, 2022
@Baroshem Baroshem added this to To do in 1.2.0 via automation Feb 25, 2022
@disha1202
Copy link

Hi,
I would like to work on this issue.
Can you please assign it to me?

@Baroshem
Copy link
Collaborator Author

Baroshem commented Feb 28, 2022

Hey @disha1202

Yes for sure, go on! If you need any help, please let me know :) Please, remember to test the project with a new Storefront UI version as it includes many breaking changes :)

@Baroshem Baroshem moved this from To do to In progress in 1.2.0 Feb 28, 2022
@disha1202
Copy link

Hello @Baroshem

I have upgraded the version of SFUI to 0.12.0 and as per the migration guide,
https://docs.storefrontui.io/iframe.html?id=releases-v0-12-x-latest-v0-12-0-migration-guide--page&viewMode=story
It's important to have explicit width and height for SfImage component.

What should be the explicit height and width for SfImage component?

@Baroshem
Copy link
Collaborator Author

Baroshem commented Mar 2, 2022

@disha1202

It depends really from the place where it is used. I would recommend checking how it is done right now and apply the same height and width to it :)

@disha1202
Copy link

@disha1202

It depends really from the place where it is used. I would recommend checking how it is done right now and apply the same height and width to it :)

Sure I'll do that.
Thanks :)

@Baroshem Baroshem added this to In progress in 2.0.0 May 12, 2022
@Baroshem Baroshem modified the milestones: 1.2.0, 2.0.0 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hackathon
Projects
2.0.0
In progress
1.2.0
In progress
Development

No branches or pull requests

2 participants