Skip to content

Change Log for November 2019 APG 1.2 Working Draft 3

Matt King edited this page Nov 15, 2019 · 3 revisions

Initial Changes for v1.2 (pull #719)

By James Nurthen on Tue Jun 19 17:12:25 2018 -0700

Change title to 1.2. Change all ARIA 1.1 references and links to 1.2

View commit 9abf6c47

Add ARIA 1.2 IDL example for button (pull #718)

By James Nurthen on Tue Jun 19 17:19:22 2018 -0700

View commit 738eaa65

IDL Button Example: Correct typos in js comments

By Matt King on Tue Jun 19 18:40:48 2018 -0700

View commit e83ecfdb

IDL Button Example: Editorial revisions

By Matt King on Wed Jun 20 00:04:46 2018 -0700

For issue #701:

  • Revise H1 to match title
  • Add link to review issue 727
  • Add note stating example is based on draft spec
  • Fix link text for link to js file
  • Fix link text for link in footer to pattern.

View commit e0bc7b19

First draft of structural roles guidance section for issue #700 (pull #720)

By James Nurthen on Fri Jun 22 10:23:30 2018 -0700

View commit 61a8ea81

Structural Roles section: draft 2

By Matt King on Fri Jun 22 19:04:40 2018 -0700

For issue #700:

  • Added explanation of implicit semantics
  • Made list of circumstances for when using ARIA instead of HTML native is OK
  • Added 11 missing structural roles.
  • Replaced list of structural roles with table that lists HTML equivalents

View commit 17d5f8c6

Structural Roles section: editorial revision

By Matt King on Fri Jun 22 21:59:00 2018 -0700

For issue #700, editorial changes to list of circumstances where using ARIA instead of HTML is OK.

View commit bd0bfceb

Structural Roles section: Add link to review issue

By Matt King on Mon Jun 25 08:00:05 2018 -0700

View commit 0b3bce42

Update acknowledgements and participants list (pull #1090)

By Matt King on Mon Jul 15 01:03:28 2019 -0700

View commit 7633c5d5

Carousel and Spin Button: Fix links between patterns and example pages (pull #1091)

By Matt King on Mon Jul 15 04:01:55 2019 -0700

  • Fix link to carousel example page from pattern.
  • Fix links to carousel design pattern from example page.
  • Add link to date picker spin button example page in spin button pattern

View commit a2b8c17f

Date Picker Dialog: fixes bug when clicking on a disabled day (pull #1095)

By Jon Gunderson on Fri Jul 19 13:29:51 2019 -0500

In the calendar grid in the date picker dialog, days that are in a previous or next month can appear in the grid. These are disabled. Clicking them generated a JS error. This fix causes the month displayed in the grid to change to the month that includes the day clicked.

View commit ecdb87a5

Fix Merge Conflict & update refs

By James Nurthen on Thu Jul 25 14:07:08 2019 -0700

View commit 0793c5b9

Regression Tests: Run only tests associated with updated example directory (pull #1100)

By Valerie Young on Sat Aug 24 16:53:55 2019 -0400

These changes Cut down the number of tests run on each PR.

  • Tests are run by example directory, so all tests for all examples in an example directory will always be run at once.
  • But if only one example directory is updated, then only the tests for that example directory will run.
  • If any code in examples/js or examples/css is edited, then all tests are run.
  • If test/index.js or any code in test/util is edited, then all tests are run.
  • If package.json is updated, then all tests are run.
  • Changes the name format for the test files. All test files must be prepended with the directory of the example they are testing in order to easily filter tests.
  • Test report will report bad test file names.
  • Changes the format of the output from AVA's format to TAP.

View commit d40a173c

Remove Math role from Children Presentational (pull #1112)

By James Nurthen on Sat Aug 24 19:21:50 2019 -0700

Adjust guidance based on change in ARIA 1.2 draft; resolves #1076 .

View commit fbe1357b

Add 9 ARIA 1.2 roles to structural roles section (#1113)

By James Nurthen on Sat Aug 24 23:58:08 2019 -0700

To resolve #1106, add the following new 9 ARIA 1.2 roles to the structural roles section:

  • associationlist
  • associationlistitemkey
  • associationlistitemvalue
  • code
  • emphasis
  • strong
  • superscript
  • subscript
  • time

View commit 0c02beca

Date Picker Dialog example: add missing tests and fix 2 bugs (pull #1141)

By Matt King on Tue Aug 27 16:51:13 2019 -0700

Adds missing regression tests for the date picker dialog example.

Fixes two bugs:

  • The "data-date" is written as 2019-01-9 for all of the "ninth" days of the month. This was a simple off-by-one error.
  • The keyboard shortcuts "PAGE UP", "PAGE DOWN", "SHIFT+PAGE UP" and "SHIFT+PAGE DOWN" didn't re-set the tab index after the calendar was update to the new month/year.

View commit a34c63e6

Date Picker Dialog Example: hide dates from prior or next month (pull #1122)

By Jon Gunderson on Wed Aug 28 17:39:33 2019 -0500

Dates at the beginning and end of the grid that are for days in the prior or next month were displayed and disabled. To resolve issue #1121, this commit removes those dates from the grid. It also removes aria-selected from the button representing the date currently displayed in the edit field because aria-selected is not valid on button.

View commit e653a7af

NPM Packages: Bump lodash from 4.17.11 to 4.17.15 (pull #1149)

By dependabot[bot] on Sat Aug 31 02:12:06 2019 -0700

Bumps lodash from 4.17.11 to 4.17.15.

Signed-off-by: dependabot[bot] [email protected]

View commit 297613a8

NPM Packages: Bump mixin-deep from 1.3.1 to 1.3.2 (pull #1147)

By dependabot[bot] on Sat Aug 31 02:37:42 2019 -0700

Bumps mixin-deep from 1.3.1 to 1.3.2.

Signed-off-by: dependabot[bot] [email protected]

View commit f590c835

Structural Roles Section: Add deletion and insertion roles (pull #1140)

By James Nurthen on Sat Aug 31 02:40:50 2019 -0700

Resolve issue #1107 by adding insertion and deletion to the table of structural roles.

View commit 0376e866

NPM Packages: Bump lodash.merge from 4.6.1 to 4.6.2 (pull #1148)

By dependabot[bot] on Sat Aug 31 04:12:41 2019 -0700

Bumps lodash.merge from 4.6.1 to 4.6.2.

Signed-off-by: dependabot[bot] [email protected]

View commit 13e6d32d

Combobox Pattern: Revise Escape behavior (pull #1129)

By Matt King on Sat Aug 31 16:14:04 2019 -0700

For issue #1066, revises description of escape behavior. Escape may optionally clear the text box, but only if the popup is hidden before escape is pressed. Previously, the pattern implied both could happen with a single press of escape, which is inconsistent with any known implementations.

View commit 698da57b

Date Picker Spin Button Example: fix query selector (pull #1153)

By Diane Ko on Sat Aug 31 16:37:30 2019 -0700

Resolves issue #1151. The query selector for the spinbutton element was incomplete, which caused it to not query properly in Safari or IE.

This fix adds in the missing characters to the query so that it queries properly.

View commit e451c933

Structural Roles Section: Add Generic Role (pull #1146)

By James Nurthen on Sat Aug 31 22:46:43 2019 -0700

View commit 2d876cf0

Button Examples (IDL Version): Clarify purpose and code for issue 727 (pull #1161)

By Carolyn MacLeod on Fri Sep 27 16:18:43 2019 -0400

Closes #727 by making the following changes:

  • Revise introduction to clarify purpose of the example.
  • Remove "similar examples" list.
  • Set role and aria-pressed in init() method instead of staticly in HTML.
  • add comments in JS documenting the equivalent way to code without reflection.
  • Add aria-hidden and focusable==false" to the svg.

View commit 3d83acde

Spin Button Date Picker Example: Fix incrementing and decrementing past limits (pull #1154)

By Diane Ko on Fri Sep 27 21:06:02 2019 -0700

Fixes the following bugs in the date picker spin button example:

  1. The day would show NaN when decrementing past the min value or incrementing past the max value.
  2. The year would show NaN when setting to min or max with home or end keys.
  3. The year could be set beyond the min or max year by incrementing or decrementing.

View commit 559f4737

Tabs Example: use display: none; to hide panels (pull #1198)

By Zoë Bijl on Mon Oct 7 23:36:39 2019 +0200

View commit 39a79fca

Tabs Example: add type=button to button elements (pull #1185)

By Zoë Bijl on Tue Oct 8 00:17:24 2019 +0200

View commit 7461a106

All Examples: Add button type to non-submit buttons (pull #1202)

By Sarah Higley on Mon Oct 7 16:55:49 2019 -0700

View commit 545d8522

README: include extra information for first timers (pull #1152)

By Diane Ko on Tue Oct 8 07:39:08 2019 -0700

Getting started with this repo for the first time and found that there were some instructions/information that were missing. This adds the following updates:

  • Add instruction to download JDK for testing in README
  • Add information to set expectations when running npm test

View commit bc5b7ef6

Infrastructure: Enable Greenkeeper dependency management (#1103)

By greenkeeper[bot] on Fri Oct 11 11:19:15 2019 -0700

For issue #1101, enables Greenkeeper to update NPM packages and makes updates needed for latest versions of packages.

  • chore(package): update dependencies
  • docs(readme): add Greenkeeper badge
  • chore(package): update lockfile package-lock.json
  • chore: Run eslint fix for new version
  • Fix minor whitespace changes being caught by new version
  • Update CLI and require for new ava version
  • Update ava cli
  • Incorrect ava format
  • Reupdate package-lock.json after merge conflicts
  • new ava version requires string assertion messages
  • Update regression report with new ava cli

View commit 422ca618

Infrastructure: Add eslint rules from eslint:recommended config (pull #1207)

By Nick Schonning on Tue Oct 22 11:33:24 2019 -0400

Perdiscussion in issue #1180, ad the eslint:recommended shareable config to eslint. Then fix errors.

  • chore: switch to eslint:recommended
  • chore: eslint fix with new config
  • fix: no-const-assign
  • fix: no-empty
  • fix: no-useless-escape
  • fix: no-duplicate-case
  • fix: no-constant-condition
  • fix: no-unsafe-negation
  • chore: ignore no-cond-assign
  • fix: no-redeclare
  • Option collides with built-in type
  • fix: no-prototype-builtins
  • chore: ignore currently failing rules

View commit d367ea53

Editorial: fix several typos in comments (#1220)

By Nick Schonning on Wed Oct 23 07:30:46 2019 -0400

  • typo: Double word "the"

  • typo: Double word "index"

  • typo: Confrirm -> Confirm

  • typo: canidate -> candidate

View commit da4ba606

Editor Menubar Example: add named group around font style menuitemcheckboxes (pull #1160)

By Matt King on Wed Oct 23 14:40:06 2019 -0700

Resolves #914 with the following changes:

  • Add a labeled group around the menuitemcheckboxes
  • change the REL attribute to DATA-OPTION attribute
  • fixed bug with bold and italic
  • Update regression tests
  • fixed broken test for aria-disabled

View commit 0223ceb6

Accessible Name Guidance Section: Add prohibited name guidance (pull #1213)

By James Nurthen on Wed Oct 23 18:19:25 2019 -0700

Resolve issue #1077 bby modifying the accessible name and description guidance section as follows:

  • Adding a new "prohibited" value for the "Necessaty of Naming" column in the naming guidance table.
  • Adding the following roles for which naming is prohibitted to the naming guidance table:
    • caption
    • code
    • deletion
    • emphasis
    • generic
    • insertion
    • None
    • paragraph
    • presentation
    • strong
    • subscript
    • superscript

View commit 514af610

Add meter example for issue 1105 (pull #1190)

By JaEun Jemma Ku on Thu Oct 24 08:56:49 2019 -0500

Resolves #1105 by adding a CPU meter display that implements the meter pattern.

View commit 96e5afd9

Accessible Naming Guidance Section: Change log and timer guidance for ARIA 1.2 (pull #1214)

By James Nurthen on Thu Oct 24 14:52:45 2019 -0700

Resolve #1201 by modifying naming guidance for the log and timer roles. Previously names were required; ARIA 1.2 removed the naming requirement. The name guidance states that a name is now discretionary.

View commit 75320227

Multiple files: fix spelling errors (pull #1223)

By Nick Schonning on Thu Oct 24 18:48:15 2019 -0400

Fixed the following:

  • typo: thre -> three
  • typo: treatement -> treatment
  • typo: forground -> foreground
  • typo: lastt -> last
  • typo: mimimum -> minimum

View commit b18ded17

Chore: Use LTS Node version instead of "latest" (pull #1221)

By Nick Schonning on Fri Oct 25 07:46:39 2019 -0400

  • chore: Use LTS Node version instead of "latest"

  • fix: Correct syntax for LTS with NVM

View commit 0a7236ec

Datepicker Example: Correct colour contrast (issue #1170)

By Zoë Bijl on Fri Oct 25 15:01:52 2019 +0200

View commit bdc8b776

Accordion Example: Correct color contrast (pull #1200)

By Zoë Bijl on Fri Oct 25 21:09:49 2019 +0200

  • Accordion Example: Correct color contrast (Issue #1132)

  • Accordion Example: Correct (high) contrast issue (Issue #1132)

  • Accordion Example: correct input border contrast (issue #1132)

View commit e80972a6

All Example pages: Change APG version from 1.1 to 1.2 (pull #1226)

By Valerie Young on Tue Oct 29 15:53:14 2019 -0400

Resolves #1225 with the following changes:

  • Fix source formatting in a few example page title and footer nav elements
  • breadcrumb example: remove reference to 1.1 in relative file path
  • Change to relative url in toolbar/help.html
  • Update aria practices version in example code templates
  • Update every example page title and footer to 1.2

View commit c8546fea

Tests: Allow for tests that do not refer to example tables rows (pull #1227)

By Valerie Young on Fri Nov 1 16:10:57 2019 -0400

View commit cd36b4cd

Chore: Update CI to always use latest Firefox (pull #1240)

By Valerie Young on Sat Nov 2 10:42:38 2019 -0400

View commit 27e17212

Add meter design pattern (pull #1189)

By Sarah Higley on Tue Nov 5 20:21:53 2019 -0800

Resolve issue #979 by adding a section to the design patterns for elements with the meter role.

View commit 6ec616f9

Naming and Describing Section: Add guidance for blockquote, meter and time (pull #1231)

By Simon Pieters on Wed Nov 6 06:51:44 2019 +0100

  • Add naming guidance for blockquote, meter and time roles

Fixes #1212.

  • Apply suggestions from code review

Co-Authored-By: Matt King [email protected]

  • Change suggestion for blockquote; change time to Do Not Name

  • Clarify what is not supported by ATs Finish resolving #1077 by adding rows to the naming guidance by role table for blockquote, meter, and time.

View commit 7cb68585

Remove excess section element added by mistake in prior commit

By Matt King on Thu Nov 7 15:58:55 2019 -0800

View commit 3b71c9ae

Appendix sections: Fix indentation level in HTML source (pull #1252)

By Matt King on Thu Nov 7 17:11:29 2019 -0800

View commit 2f5ae535

Linting for build process: enable eslint no-fallthrough option (pull #1219)

By Nick Schonning on Fri Nov 8 00:30:00 2019 -0500

View commit b04f43d9

Add example listbox with grouped options and fix 2 listbox bugs (pull #1191)

By Sarah Higley on Thu Nov 7 22:24:34 2019 -0800

Resolves #913 by adding example of the listbox pattern that includes options that are contained by labeled groups. Includes regression tests for the new example.

Additionally, fixes these bugs in the behavior of options that are clicked with the mouse:

  • Clicking any option below the initially visible options results in the first option being selected instead of the clicked option
  • Clicking any option within the initially visible area briefly selects the first option before moving selection to the clicked option

These bugs are fixed By:

  • not immediately selecting the first option when the listbox receives focus (bringing it more inline with native <select multiple>
  • only initiating automatic listbox scroll when interacting with the keyboard

View commit d8a61c2c

Button Design Pattern: Editorial revision to put example links in a list

By Matt King on Thu Nov 7 23:26:58 2019 -0800

View commit cc2ea168

ReSpec Config: Set editors draft to github.io since master now has 1.2 content

By Matt King on Thu Nov 7 23:38:29 2019 -0800

View commit 280f66f9

Appendix: Add change log for APG 1.2 Working Draft 3(pull #1257)

By Matt King on Sun Nov 10 23:41:11 2019 -0800

Adds complete change history since the first public working draft of APG 1.1. Includes new change history section for all changes in APG 1.2 that are not in APG 1.1.

View commit ce3fac96

Menu pattern: Add statement that behavior is like native OS menus (pull #1232)

By Carolyn MacLeod on Mon Nov 11 04:27:35 2019 -0500

For issue #353,modify menu pattern to include:

Menu widgets behave like native operating system menus, such as the menus that pull down from the menubars commonly found at the top of many desktop application windows.

View commit a2b4df9e

Tabs pattern: Add aria-orientation reference to note about arrow key behavior (pull #1193)

By Adrian Roselli on Mon Nov 11 04:46:09 2019 -0500

For issue 976, add a reference to aria-orientation in the note that describes how vertically orienting tabs changes arrow key behavior.

View commit 2b1c5b12

Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification (pull #1255)

By Matt King on Thu Nov 14 20:02:02 2019 -0800

To resolve #1250 and resolve #1244:

  1. Revise the combobox pattern to remove the ARIA 1.0 and ARIA 1.1 guidance and replace with ARIA 1.2 guidance. Keeps a note about ARIA 1.0.
  2. In examples, remove ARIA 1.0 and ARIA 1.1 pattern subdirectories and examples.
  3. Convert the 3 ARIA 1.0 listbox popup examples into a 1.2 example.
  4. Convert the ARIA 1.1 grid popup example into a 1.2 example.
  5. Revise regression tests for combobox examples to test the 1.2 versions.

View commit 632bc8a9

Editorial: Final prep of master for working draft publication (pull #1269)

By Matt King on Thu Nov 14 22:19:05 2019 -0800

  • Update index of examples
  • Structural roles section: Remove link to feedback issue 739 and 3 rows for association list
  • Rebuild example index after merge of new combobox examples

View commit 089638b0

Clone this wiki locally