Small optimization: remove needless code from internal sched() calls #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we call timeout_sched() internally, sometimes we can be sure that the timeout is in the future. Always, we can be sure that the timeout has its expires field and its timeouts field set correctly, and that it is not currently pending. (Do not merge this patch without benchmarking to see if it makes a measurable difference.)
|
This will conflict with #15; I'm happy to help with the merge if you want to take both. |
|
Hm, we'd better be careful here. I just ran the benchmarks over master and all 3 of these branches, and to my surprise they don't show a very large improvement. (I wasn't very careful in my setup, though, so maybe better benchmark run would show results better.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call timeout_sched() internally, sometimes we can be sure
that the timeout is in the future. Always, we can be sure that the
timeout has its expires field and its timeouts field set correctly,
and that it is not currently pending.
(Do not merge this patch without benchmarking to see if it makes a
measurable difference. I haven't benchmarked it, and it might well turn out
not to actually help in practice.)