Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider Job emailChecker #143

Open
Martinsos opened this issue May 23, 2024 · 0 comments
Open

Reconsider Job emailChecker #143

Martinsos opened this issue May 23, 2024 · 0 comments
Labels

Comments

@Martinsos
Copy link
Member

Is this job really needed? Seems a bit like redundant functionality. We do have job dailyStatsJob to showcase jobs.

I would consider dropping job emailChecker from open-saas.

Or, let’s at least make it a bit more interesting / practical: let’s make it send weekly summary to each user, of their activities. And give it a better name then also, like emailWeeklySummary. Yeah I can see myself using that. is that easy to make without knowing more about the app though?

Btw what if users don’t see that they have this job in their app → I can easily imagine them not noticing (it is at the end of the main.wasp file and you don't see its effects unless it hits Monday at 7am), and then in production email suddenly gets sent to users!
So maybe by default this should be turned off somehow? Or we should delete it hm. I like the functionality being there if we need it, but it is a bit much / can cause problems.

TLDR: I would either delete it, or make it more practical + make sure they have to somehow enable it and not have it working by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant