Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping intro spamming and video doesn't work #148

Open
1basti1 opened this issue Mar 30, 2024 · 9 comments
Open

Skipping intro spamming and video doesn't work #148

1basti1 opened this issue Mar 30, 2024 · 9 comments
Labels
bug Something isn't working
Milestone

Comments

@1basti1
Copy link

1basti1 commented Mar 30, 2024

I use build 0.3.3 dev3 (because ads were showing on the stable build)
and just experienced this:

https://streamable.com/keh49r

fyi It's a video with segments. Trying to skip to somewhere in the video doesn't work. (if you pause the video and skip 10 sec and then play, it does work normally, it only has this problem at the exact beginning of that video)

I never saw that before.
When I turn sponsorblock off and restart the app the problem is gone.

Edit: newest Linus tech tips video also has segments and it isn't happing there. Maybe only a problem with this specific video ( https://youtu.be/ntz2c2z54dg )?
When I look at that video in revanced, there is no problem and it seems it doesn't even has a intro to skip.

@throwaway96
Copy link
Member

Interesting. What webOS version and SoC/OTAID?

I assume this is due to #103. (I tested it mostly on Linus Tech Tips videos.) I want to do a release soon, so I might revert that for now (or at least create a branch without it to do the release from).

Although I doubt it'll make a difference, could you please try 0.3.3-dev5?

@1basti1
Copy link
Author

1basti1 commented Mar 30, 2024

SoC/OTAID I actually don't know. (where would I see this? Sorry, I'm mostly just an end user)
It's a OLED55C97LA with firmware 05.20.07

I can maybe try dev5 tommorow. Not at home for the test of the day

@throwaway96
Copy link
Member

The OTAID for that model is HE_DTV_W19O_AFABABAA, and it has an O18 SoC. There are instructions for finding it in the crashd guide.

Looks like that firmware version corresponds with webOS 4.9.5.

@throwaway96
Copy link
Member

When you get a chance, please try 0.3.3-dev6. It doesn't have the multi-chapter SponsorBlock support.

@throwaway96 throwaway96 added this to the v0.3.3 milestone Mar 30, 2024
@1basti1
Copy link
Author

1basti1 commented Mar 31, 2024

I'll try in 2-3h and let you know.

@1basti1
Copy link
Author

1basti1 commented Mar 31, 2024

Ok, I just tried dev6 and problem ist still there. (I made sure sponsorblock isn't shown in segments on the newest Linus tech tips video)

So, it doesn't seem to be segment related. Maybe it's really just this (linked) video.

@1basti1
Copy link
Author

1basti1 commented Mar 31, 2024

Ok, it even happens on the latest stable build 0.3.2 .
I click on the video, a YouTube ad starts playing and it spams skipping intro.

So probably just this video. For whatever reason. ive watched many videos and this is the only one where that ever happend.

https://youtu.be/ntz2c2z54dg

I'll go back to dev5. So actual ad block will work and sponsorblock is shown on segmented videos.

Let me know if I should test anything further.

On dev5 sponsored tiles is showing. (the first tile in recommended) (edit: but not everytime, but that particular ad doesn't bother me much)
I don't think this was shown on dev3 yesterday. But could be wrong.

@cremor
Copy link

cremor commented Mar 31, 2024

This might be because the sponsor segement is too short to actually skip. So it might try to skip after it, but the nearest possible seek point is actually still before the segment.

The desktop SponsorBlock addon automatically ignores the segment because it's too short. If you open the SponsorBlock panel on desktop you will see a segment from 0:00.000 to 0:00.184 with the note "hidden: too short". Maybe such an automatic ignore feature of too short segments should be added to this app too?
The minimal duration is configurable on desktop, but if I remember correctly it was set to 1 second by default.

Also, this might be the same as reisxd/TizenTube#27

@throwaway96
Copy link
Member

Guess it's not #103 then. In that case, it'll have to wait for the next release.

@throwaway96 throwaway96 modified the milestones: v0.3.3, v0.3.4 Mar 31, 2024
@throwaway96 throwaway96 added the bug Something isn't working label Mar 31, 2024
@throwaway96 throwaway96 modified the milestones: v0.3.4, future Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants