Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Installation instructions unclear #180

Open
ShalokShalom opened this issue Jun 12, 2024 · 1 comment · May be fixed by #183
Open

Bug: Installation instructions unclear #180

ShalokShalom opened this issue Jun 12, 2024 · 1 comment · May be fixed by #183
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ShalokShalom
Copy link

YTAF information

  • YTAF version: 0.3.4

TV information

modelName : OLED55E97LA
sdkVersion : 4.10.0
firmwareVersion : 05.40.35
boardType : O18_DVB_EU
otaId : HE_DTV_W19O_AFABABAA

Hi there!

I found the instructions on the README to be incorrect for my installation process.
Instead, the linked guide on the LG homepage helped me.

In particular, entering the line described here was not sufficent to establish the passkey.
Screenshot_20240612_130722

Instead, it was needed to register it via ares-novacom --device tv2 --getkey

I suggest to double check, if the described method is still valid.
I can rework the guide, once its confirmed that its not.

The described method yielded the following issue:

Screenshot_20240612_125732

@ShalokShalom ShalokShalom added the bug Something isn't working label Jun 12, 2024
@throwaway96
Copy link
Member

throwaway96 commented Jun 16, 2024

It appears ${HOME}/.ssh (or %USERPROFILE%\.ssh on Windows) is prepended to the path given for private key files.

lib/base/novacom.js:31

    const keydir = path.resolve(process.env.HOME || process.env.USERPROFILE, '.ssh');

lib/base/novacom.js:200

                    fs.readFile.bind(this, path.join(keydir, inDevice.privateKey.openSsh), next),

Which is incredibly unintuitive. I guess for now keys just have to go in ~/.ssh.

@throwaway96 throwaway96 added the documentation Improvements or additions to documentation label Jun 16, 2024
@throwaway96 throwaway96 linked a pull request Jun 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants