Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of get_oracle_summary function #15

Open
pcshih opened this issue Aug 6, 2019 · 28 comments
Open

implementation of get_oracle_summary function #15

pcshih opened this issue Aug 6, 2019 · 28 comments

Comments

@pcshih
Copy link

pcshih commented Aug 6, 2019

https://github.com/weirme/Video_Summary_using_FCSN/blob/0895cccbb2a488369b1bfc7d2c087b3050250898/make_dataset.py#L70

What is the meaning of this function?

@weirme
Copy link
Owner

weirme commented Aug 6, 2019

This function generates a summary from summary of 20 users in the dataset.

@pcshih
Copy link
Author

pcshih commented Aug 6, 2019

The implementation is based on which paragraph of FSCN paper or other paper?

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

Chapter 3.1 of this paper: Diverse sequential subset selection for supervised video summarization. In my implementation, the greedy algorithm selects the frame marked by the most users each time.

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

After reading Chapter 3.1, I still cannot realize the process.
Given 3 human summaries with 5 frames:
A: [1,0,1,1,0]
B: [0,0,1,0,0]
C: [0,0,0,1,0]

How to get the final summary?
First: calculate the select times of each frame -> [1,0,2,2,0]
Second: I have no idea...

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

In my implementation, initialize oracle summary as [0, 0, 0, 0, 0], and then pick the most selected frame (here the third), now the oracle summary will be [0, 0, 1, 0, 0]. Determine if the F-score between oracle summary and user summary increases after adding this frame. If true, continue to select next frame, otherwise it ends.
But it is just my implementation, I didn't find a specific description of the greedy algorithm used in the paper. So I'm not sure if the algorithm is like this.

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

Where is FCSN mentioned that they use "Diverse sequential subset selection for supervised video summarization" for generating a summary from summary of users?

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

This method is mentioned in supplementary materials of paper Video Summarization with Long Short-term Memory.

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

After I read the paragraph, I implement it.

https://github.com/pcshih/pytorch-FCSN/blob/7d4f874f6c71d5b279b6e26a6ee4882460230fc9/make_dataset.py#L84

Is my understanding identical to yours?

But the performance is quite bad...

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

Have you print the final F-score between generated oracle summary and user summary?

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

Did you mean the parameter "best_fscore"?

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

best_fscore_1
best_fscore_2

It seems slightly different.

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

https://github.com/KaiyangZhou/pytorch-vsumm-reinforce/blob/fdd03be93f090278424af789c120531e49aefa40/main.py#L164

I found that tvsum use avg but summe use max when evaluating.
After I change summe to max, my result gets better.

But I do not know why to use this method...

FCSN_1D_summe_eval_max

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

Could you share the tvsum video on your google drive?
tvsum needs authorization....

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

https://github.com/KaiyangZhou/pytorch-vsumm-reinforce/blob/fdd03be93f090278424af789c120531e49aefa40/main.py#L164

I found that tvsum use avg but summe use max when evaluating.
After I change summe to max, my result gets better.

But I do not know why to use this method...

FCSN_1D_summe_eval_max

Is this result on SumMe? It seems close to that in paper!

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

Could you share the tvsum video on your google drive?
tvsum needs authorization....

Wait a moment, I'm now uploading it...

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

https://github.com/KaiyangZhou/pytorch-vsumm-reinforce/blob/fdd03be93f090278424af789c120531e49aefa40/main.py#L164
I found that tvsum use avg but summe use max when evaluating.
After I change summe to max, my result gets better.
But I do not know why to use this method...
FCSN_1D_summe_eval_max

Is this result on SumMe? It seems close to that in paper!

Yes, it is summe.

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

Could you share the tvsum video on your google drive?
tvsum needs authorization....

Wait a moment, I'm now uploading it...

Thank you

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

Here is the link.

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

May be it is a default setting in evaluation? I also think it's strange...
And I noticed that selected key frames of videos in summe differ greatly from each user, F-score between generated oracle summary and user summary is only nearly 50%, but that is nearly 70% in tvsum. In this case, getting a summary close to every user seems to be difficult. Is this probably a reason to select max?

@pcshih
Copy link
Author

pcshih commented Aug 7, 2019

I agree with your opinion. Let's take this evaluation method for granted.
I also implement this paper which architecture is based on FCSN but there are some problems...

@weirme
Copy link
Owner

weirme commented Aug 7, 2019

I have not read this paper yet, its architecture looks complicated.

@pcshih
Copy link
Author

pcshih commented Aug 8, 2019

Do you have any idea of FCSN in unsupervised version?

@weirme
Copy link
Owner

weirme commented Aug 8, 2019

No... I skip that part when reading the paper...

@pcshih
Copy link
Author

pcshih commented Aug 8, 2019

Shall we implement that part?

@weirme
Copy link
Owner

weirme commented Aug 8, 2019

I will try to implement it after reading that part, but there may be some problems because my computer at home doesn't have a nvidia gpu 😅😅

@pcshih
Copy link
Author

pcshih commented Aug 8, 2019

I am counting on you.

@Pager07
Copy link

Pager07 commented Oct 19, 2020

Here is the link.

Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants