Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not registering different ids of the same avro entity #51

Open
danielwitz opened this issue Apr 25, 2019 · 2 comments
Open

Not registering different ids of the same avro entity #51

danielwitz opened this issue Apr 25, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@danielwitz
Copy link
Contributor

Describe the bug
When there are multiple ids to the same avro entity in the schema registry grabbit registers the first one (The one with the smaller id I think) and rejects the others as the entity is "already registered" in the map.
When an entity from the unregistered schema arrives grabbit fails the serialisation.

@rhinof rhinof added the bug Something isn't working label Apr 25, 2019
@rhinof
Copy link
Contributor

rhinof commented May 9, 2019

@danielwitz WDYT should be the expected behavior in this case?

@danielwitz
Copy link
Contributor Author

IMO, we should change the schemas map key to a schema name, schema id pair so in the case described both schemas are registered and when an object arrives with either of the schemas the serialization succeeds.
I think this is the more "whole" solution that ignores the type of the registry (backwards compatible, full transitive, none, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants