Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with target search #123

Open
xandao-dev opened this issue Feb 22, 2020 · 8 comments
Open

Bug with target search #123

xandao-dev opened this issue Feb 22, 2020 · 8 comments
Labels
bug Something isn't working gssoc21 hard advance issue help wanted Extra attention is needed

Comments

@xandao-dev
Copy link
Collaborator

I've been noticing some bugs in the current targeting method.

Bug 1

If you have 2 contacts with the same name, only 1 will be listed.
I don't know why yet.

Bug 2

False-positive groups, sometimes people appear in the group listing.
This is because the selector that takes the name of the groups also takes the status of the people and when that status contains the searched name it is also included in the groups!

How to solve Bug 1 and 2?

Maybe we could enter in every target filtered and get the target title. This could solve both bugs.
@xandao-dev xandao-dev added the bug Something isn't working label Feb 22, 2020
@xandao-dev xandao-dev added the help wanted Extra attention is needed label Feb 22, 2020
@bhngupta
Copy link

Hey, can I work on this issue?

@xandao-dev
Copy link
Collaborator Author

Hey, can I work on this issue?

@Bhanu-mbvg sure, will be counted for GSSoC only after March 1st

@rpotter12
Copy link
Member

I recommend to solve 1 bug in 1 PR.

@rpotter12 rpotter12 added the medium average issue label Feb 29, 2020
@xandao-dev xandao-dev changed the title Bug with target search Bug 2 with target search Mar 1, 2020
@xandao-dev xandao-dev changed the title Bug 2 with target search Bug with target search Mar 1, 2020
@xandao-dev
Copy link
Collaborator Author

@rpotter12 the solution will fix both.

@xandao-dev
Copy link
Collaborator Author

@Bhanu-mbvg Assigned to you, you have 4 days.

@xandao-dev xandao-dev added hard advance issue and removed medium average issue good first issue labels Mar 1, 2020
@xandao-dev
Copy link
Collaborator Author

@Bhanu-mbvg deadlined extended +4d

@xandao-dev
Copy link
Collaborator Author

@Bhanu-mbvg how is it going?

@xandao-dev
Copy link
Collaborator Author

Now we already have a function to enter in target and get the data, but we don't verify if is the same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gssoc21 hard advance issue help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xandao-dev @rpotter12 @bhngupta