Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Diamond from a MultiSig wallet #498

Open
Jcalcaldev opened this issue Nov 28, 2023 · 2 comments
Open

Upgrading Diamond from a MultiSig wallet #498

Jcalcaldev opened this issue Nov 28, 2023 · 2 comments

Comments

@Jcalcaldev
Copy link

I'm having some issues trying to change an existing diamond's owner to a multisig and then upgrading it through hardhat deploy.

I'm using catchUnknownSigner to get the deployment transaction's raw data and execute it in the multisig (Gnosis) transaction builder.

Using this method, some deployment files are generated, but not the most important one (Game.json in my case), which contains these properties:

  • address
  • abi
  • transactionHash
  • receipt
  • numDeployments
  • solcInputHash
  • metadata

These files are generated when executing the deployment script, so once the transaction is executed on Gnosis, commiting the generated files should be fine, but some files are missing as mentioned.

Also, executing the script but not the deployment transaction on Gnosis still appears to create lone facets with the new functionality, but not connected to the main diamond contract.

Is there a verified method to do this correctly? Any help is really appreciated!

@maikelordaz
Copy link

maikelordaz commented Feb 2, 2024

@Jcalcaldev Have you found a way for this? What I'm doing to get the ABI is deploying on localhost, but ould like to have the correct abi for the proxy when I deploy on mainnet to the multisig

@jdbertron
Copy link

I'm curious as well. This sounds like your hh-deploy is skipping the diamond cut operation. Can you tell us how you solved this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants