Processing Jumpers and Loops, Plus Processing Wires inside the Table as Edges #369

tobiasfalk · 2024-05-30T14:31:57Z

Here I started to implement Jumpers, and a new way of drawing Wires inside the Wire table.

Currently, only the Black circles are done and nothing else.
See ex15.png
Ps. And now even the right branch

Edit:
Ex15:

Ex16:

tobiasfalk · 2024-05-30T20:37:41Z

Now everything from #350 is implemented.

tobiasfalk · 2024-05-30T20:38:19Z

Syntax:

connectors:
  X1:
    type: Molex KK 254 # more information
    subtype: female
    pinlabels: [GND, VCC, RX, TX, GND, VCC, GND] # pincount is implicit in pinout
    internal_shorts: [[1, 5, 7], [2, 6]]
    internal_shorts_color: [PK, RD]
  X2:
    type: Molex KK 254
    subtype: female
    pinlabels: [GND, VCC, RX, TX, GND, VCC, GND]
    internal_shorts: [[1, 5, 7], [2, 6]]

Changed the syntax and added options for the shorts, see ex15 for more

tobiasfalk · 2024-06-05T23:02:49Z

New Syntax:

connectors:
  X1:
    type: Molex KK 254 # more information
    subtype: female
    pinlabels: [GND, VCC, RX, TX, GND, VCC, GND] # pincount is implicit in pinout
    shorts:
      SH1:
        pins: [1, 5, 7]
        color: PK
        manufacturer: WireViz
        mpn: 42XCD42A5
        description: shortPart
      SH2:
        pins: [2, 6]
        color: RD
        manufacturer: WireViz
        mpn: 42XCD42A5
        description: shortPart
        length: 42

tobiasfalk · 2024-06-05T23:04:35Z

tobiasfalk · 2024-06-08T23:50:05Z

ex16:

kvid · 2024-06-09T09:32:12Z

I'm sorry that I've not yet had time to play with this PR, but it seems to work as proof of concept for the #350 discussions.

I suggest that you activate "convert to draft" while this is work-in-progress (I do forget that with my PRs also sometimes).
Be aware that your latest syntax expansion probably will need coordinaton with changes in Large scale refactoring #251 that is first in line for merge into dev.
The way you want to combine internal shorts and loops, might also need a discussion in Way to implement Jumpers/Interconnects #350 because I fear it will be too complicated for the simplest use cases.

tobiasfalk · 2024-06-09T10:09:24Z

I mainly have problems with the bom and how I add the shorts to the bom

kvid · 2024-06-09T10:27:47Z

I mainly have problems with the bom and how I add the shorts to the bom

Have you considered making the additional components list be a union of shorts and explicitly specified entries, instead of having a separate list for shorts? Then adding to BOM could be handled equally as well.

tobiasfalk · 2024-06-14T23:35:20Z

@kvid @martinrieder could you look at the new syntax in ex15 & 16?

martinrieder

This needs a bit of rework. Comments added.

examples/ex15.yml

martinrieder · 2024-06-15T07:23:26Z

examples/ex15.yml

+        manufacturer: WireViz
+        mpn: 42XCD42A5
+        type: shortPartA
+        qty: 42


I find qty confusing for unit mm. How about length as an alias?

Yes, but Additional Components works with qty

Yes, just leave it, as changing this is not in scope.

examples/ex16.yml

examples/ex15.tmp

martinrieder · 2024-06-15T09:01:29Z

examples/ex15.yml

+    shorts:
+      - SH1: [1, 5, 7]
+      - SH2: [2, 6]


Using a list here is fine. Does not match the syntax description though.

Syntax description is yet to be updated.

src/wireviz/Harness.py

martinrieder · 2024-06-15T09:22:25Z

src/wireviz/wv_bom.py

+                }
+            else:
+                common_args = {
+                    "qty": part.qty * component.get_qty_multiplier(part.qty_multiplier),


numShorts could be the return value of the function.

Do not completely understand what you mean

@martinrieder ?

You had the qty_multiplier choice extended for shorted, so I thought that the function get_qty_multiplier might return numShorts as an integer in that case. The meaning has changed now with references.

martinrieder · 2024-06-15T09:22:48Z

src/wireviz/wv_bom.py

+            else:
+                numShorts = len(part.shorts)
+
+            if numShorts > 0:


This could be avoided, see below.

Do not completely understand what you mean

@martinrieder ?

Sorry, the order of comments got mixed up and my statement was possibly misleading.

tutorial/tutorial01

tobiasfalk · 2024-06-15T14:05:10Z

Overall question is if the syntax is acceptable?
If so Checks and other things can be done.

martinrieder · 2024-06-15T15:35:51Z

@tobiasfalk wrote:

Overall question is if the syntax is acceptable?

I would prefer a solution that does not require using loops or shorts in two different locations. Alternatively, I suggest to use a reference key instead for both, since designators have to be unique anyways. It will also avoid the situation like in ex15 where loops and shorts got unintentionally mixed up.

Overall, I would say that this implementation is quite close to what was discussed in #224 (comment). The only difference is that reference was implied, but implementing that is a little more tricky. Still, I think that we should clarify the outcome of #224 before merging this PR.

Please also have a look at #288, which also implements some loop handling and might cause some merge issues. What I need for my daily work is having alphanumeric pin names and pinlabels matching to work also on loops. I am currently using a workaround for this.

ex15

connectors:
  X1:
    #[...] 
    pinlabels: [GND, VCC, RX, TX, GND, VCC, GND]
    shorts:
      - SH1: [1, 5, 7]  
      - SH2: [2, 6]
    additional_components:
      - reference: SH1 # discussed in #224
        color: PK
        #[...] 
        
      - reference: SH2
        color: RD
        #[...] 

  X2:
    #[...] 
    pinlabels: [GND, VCC, RX, TX, GND, VCC, GND]
    shorts:
      - SH1: [1, 5, 7] # same designator as above... 
      - SH2: [2, 6]   # does this imply the same attributes?

EDIT: Cross-referring to #224 (comment) for additional details.

… bom

martinrieder · 2024-06-16T22:42:35Z

Just adding lables will make it ugly, maybe some text in the connector table?

Yes, I was thinking the same. You would also need to name the color, similar to how it is done for wires. For the colorblind it seems impossible to recognize the loops otherwise.

What about choosing a connector side for loops?

tobiasfalk · 2024-06-16T22:47:57Z

@martinrieder
I have the Idea to add additional_cable to the connector and add references like with AddComp. Would also "solve" your complaint about the unit/qty attribute.

martinrieder · 2024-06-17T05:07:10Z

@tobiasfalk please explain your reasoning... The way I understand this, it could be solved by #376, which also allows defining a connector side for loops. It would not be displayed in the additional components table then.

I would call the two approaches:

explicit loops with additional_components as handled by this PR, based on
implicit loops defined through separate cable (like [feature] Single wire cable drawn without table #376)

tobiasfalk · 2024-06-17T05:21:18Z

@martinrieder my reasoning behind it was to group it with the same type of wire/cabel in the overall bom.
But this can also be added later.

tobiasfalk · 2024-06-17T05:42:08Z

If the base is OK, I will add a tutorial and then wait for #251 to then move/reimplement this. Since this will create a bunch of conflicts.

tobiasfalk · 2024-06-17T22:44:32Z

@martinrieder
About the Problems with the Black Circle, I really do have no Idea to have a fix for all systems, since fonts often have rendering problems.
I asked for help in the GraphViz Forum: https://forum.graphviz.org/t/way-of-drawing-a-black-circle-inside-a-table-field/2273

I thought about that maybe replacing it with an X but then the centering Problem of SVG would be more prominent.

martinrieder · 2024-06-18T04:48:30Z

@tobiasfalk how does the × multiplication sign (×) perform instead of the letter X?
It is part of ISO/IEC 8859-1 that can be explicitly defined through the charset attribute.

tobiasfalk · 2024-06-18T04:51:11Z

You will have the same Problem as with X

tobiasfalk · 2024-06-18T04:54:04Z

Also, it is kinda small:
PNG:

SVG:

martinrieder · 2024-06-18T15:10:56Z

@tobiasfalk I finally got around to test your PR on my dev machine. It fails to run gvpr due to a path issue or missing environment variable:

Error: gvwrite_no_z problem 57
gvpr: Could not find file "pin2pin.gvpr" in GVPRPATH

You may need to use an absolute path for calling this script. I tried to set the environment variable to point to the right path and also moved pin2pin.gvpr` into the same folder, but it fails to run.

tobiasfalk · 2024-06-18T15:12:41Z

@tobiasfalk I finally got around to test your PR on my dev machine. It fails to run gvpr due to a path issue or missing environment variable:
Error: gvwrite_no_z problem 57
gvpr: Could not find file "pin2pin.gvpr" in GVPRPATH
You may need to use an absolute path for calling this script. I tried to set the environment variable to point to the right path and also moved pin2pin.gvpr` into the same folder, but it fails to run.

Will look in to it

martinrieder · 2024-06-18T15:49:06Z

@tobiasfalk I fixed it by adding the line

os.environ['GVPRPATH'] = str(Path(__file__).parent)

tobiasfalk · 2024-06-18T16:16:31Z

@martinrieder to where exactly?

martinrieder · 2024-06-18T16:40:46Z

Just before the call to gvpr in the if branch with find_executable in harness.py.

tobiasfalk · 2024-06-18T21:02:00Z

@martinrieder could you test it again?

tobiasfalk · 2024-06-18T21:20:20Z

Some commits back, do not know exactly which one, I implemented #352 and it works without a problem for me

martinrieder · 2024-06-19T03:07:10Z

Then I propose you edit the description of the PR to include this and the other issues from #369 (comment) as well.

tobiasfalk · 2024-06-19T11:16:31Z

If everything is now Ok, then I would now wait for #251
Is there a Time frame for when it will be merged? Since the last update on it was in April(2 months ago)

tobiasfalk · 2024-06-19T11:17:43Z

Oh yes I need to clean up the code a bit, I know that

tobiasfalk added 2 commits May 30, 2024 16:26

Added Dark Circles

465aefa

Added dashed lines

a015da5

tobiasfalk changed the title ~~[WIP] Jumpers, A start to implement #350~~ Jumpers, implementaition of #350 May 30, 2024

tobiasfalk added 2 commits June 1, 2024 11:09

Made line from dashed to solid bold

8c97c5d

Added Documentaion

ee5b292

amotl changed the title ~~Jumpers, implementaition of #350~~ Processing Jumpers Jun 4, 2024

Added more options for shorts

f49921b

Changed the syntax and added options for the shorts, see ex15 for more

tobiasfalk mentioned this pull request Jun 5, 2024

Way to implement Jumpers/Interconnects #350

Open

tobiasfalk added 2 commits June 8, 2024 14:17

more to added more options

02fcc68

Added type for shorts(loop or internal), see ex16

be801c3

tobiasfalk marked this pull request as draft June 9, 2024 10:00

tobiasfalk added 2 commits June 9, 2024 21:44

Added Bom entrys and removed grapgh bom

11e4611

add synrax description

cd1f489

kvid mentioned this pull request Jun 12, 2024

Improving additional component display, BOM item numbers #224

Open

Updated Syntax to make the shorts as Aditional Component

0801d7b

martinrieder reviewed Jun 15, 2024

View reviewed changes

fix multicoolr Straitening

1b90104

tobiasfalk mentioned this pull request Jun 16, 2024

Proposal for new way to draw Wires in the Wire box #352

Open

Changed AddComp shorts to references and added the designators to the…

b5aa1c2

… bom

martinrieder mentioned this pull request Jun 17, 2024

Ability to Specify Jumpers #286

Open

Add fix for overcsiced loops, try 2

39251f5

Added some Graphviz Magic for drawing Dots at the end of straight lines

e0ae9be

tobiasfalk added 2 commits June 18, 2024 23:09

Clean up and some checks

2680a12

re run the examplse

0f5c612

tobiasfalk changed the title ~~Processing Jumpers and Loops~~ Processing Jumpers and Loops, Plus Processing Wires inside the Table as Edges Jun 18, 2024

tobiasfalk added 2 commits June 19, 2024 12:49

added a copy for the pin2pin file and a message on how to use

fa034c5

Added tutorial09 for shorts and loops

9e54d02

tobiasfalk added 3 commits June 19, 2024 16:56

Cleand up and added comends, description in the readme

e0dd2c1

changed color code of ex15, for testing of the edge inside of the table

6ba3f25

rerun examples

f0b242d

Processing Jumpers and Loops, Plus Processing Wires inside the Table as Edges #369

Are you sure you want to change the base?

Processing Jumpers and Loops, Plus Processing Wires inside the Table as Edges #369

Conversation

tobiasfalk commented May 30, 2024 • edited Loading

tobiasfalk commented May 30, 2024

tobiasfalk commented May 30, 2024

tobiasfalk commented Jun 5, 2024

tobiasfalk commented Jun 5, 2024

tobiasfalk commented Jun 8, 2024

kvid commented Jun 9, 2024 • edited Loading

tobiasfalk commented Jun 9, 2024

kvid commented Jun 9, 2024

tobiasfalk commented Jun 14, 2024

martinrieder left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tobiasfalk Jun 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tobiasfalk commented Jun 15, 2024

martinrieder commented Jun 15, 2024 • edited Loading

martinrieder commented Jun 16, 2024 • edited Loading

tobiasfalk commented Jun 16, 2024 • edited Loading

martinrieder commented Jun 17, 2024 • edited Loading

tobiasfalk commented Jun 17, 2024

tobiasfalk commented Jun 17, 2024

tobiasfalk commented Jun 17, 2024

martinrieder commented Jun 18, 2024 • edited Loading

tobiasfalk commented Jun 18, 2024

tobiasfalk commented Jun 18, 2024 • edited Loading

martinrieder commented Jun 18, 2024

tobiasfalk commented Jun 18, 2024

martinrieder commented Jun 18, 2024 • edited Loading

tobiasfalk commented Jun 18, 2024

martinrieder commented Jun 18, 2024

tobiasfalk commented Jun 18, 2024

tobiasfalk commented Jun 18, 2024 • edited Loading

martinrieder commented Jun 19, 2024 • edited Loading

tobiasfalk commented Jun 19, 2024

tobiasfalk commented Jun 19, 2024

tobiasfalk commented May 30, 2024 •

edited

Loading

kvid commented Jun 9, 2024 •

edited

Loading

martinrieder left a comment •

edited

Loading

tobiasfalk Jun 16, 2024 •

edited

Loading

martinrieder commented Jun 15, 2024 •

edited

Loading

martinrieder commented Jun 16, 2024 •

edited

Loading

tobiasfalk commented Jun 16, 2024 •

edited

Loading

martinrieder commented Jun 17, 2024 •

edited

Loading

martinrieder commented Jun 18, 2024 •

edited

Loading

tobiasfalk commented Jun 18, 2024 •

edited

Loading

martinrieder commented Jun 18, 2024 •

edited

Loading

tobiasfalk commented Jun 18, 2024 •

edited

Loading

martinrieder commented Jun 19, 2024 •

edited

Loading