Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #108 rolls back fix #57 #110

Closed
schellingerhout opened this issue Mar 3, 2017 · 5 comments
Closed

Pull request #108 rolls back fix #57 #110

schellingerhout opened this issue Mar 3, 2017 · 5 comments

Comments

@schellingerhout
Copy link
Contributor

schellingerhout commented Mar 3, 2017

Merge pull request #108 rolls back fix #57 and again causes issue #56 (as well as its related\duplicates #11, #17, #19)

Tested on windows 10 with npm at location with space "C:\Program Files\nodejs\npm" release 2.4.0 works, 2.4.1 produces the error.

@schellingerhout
Copy link
Contributor Author

Temporary workaround for Windows users that installed npm to a location with a space in the name is to install 2.4.0

npm install [email protected] -g

@watilde
Copy link
Member

watilde commented Mar 3, 2017

Oh I'm sorry to hear it.. I will have a look it. Thanks for reporting it.

@watilde
Copy link
Member

watilde commented Mar 3, 2017

Hmm maybe it's better to replace them with "npm". I will test it on my Windows laptop later, and make a patch.

If anyone can take this issue, feel free to do that :)

@schellingerhout
Copy link
Contributor Author

schellingerhout commented Mar 3, 2017

@watilde I believe since the issues you were attempting to fix were actually already addressed, the fix is to roll back to 2.4.0. Mentioning @EmmaRamirez since she reviewed

@watilde
Copy link
Member

watilde commented Mar 4, 2017

I'm going to close this as resolved by #112

@watilde watilde closed this as completed Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants