Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to avoid server crash in exercise 8 isomorphic (#111) #118

Merged
merged 2 commits into from
May 7, 2017
Merged

Fix to avoid server crash in exercise 8 isomorphic (#111) #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca42fb0
Fix to avoid server crash in exercise 8 (#111)
kaz080 Jan 31, 2017
25695b1
Also fix solution.js in exercise 8 (#111)
kaz080 Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions exercises/isomorphic/problem.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ var babelify = require("babelify");
Next, add a line that reads `index.jsx` under the sentence that `require` s `babel/register`.

```
require('babel/register')({
ignore: false
});
require('babel/register');

var TodoBox = require('./views/index.jsx');
```
Expand All @@ -67,12 +65,8 @@ If you have an access to `/`, you response HTML that consists of reading `index.
app.use('/bundle.js', function (req, res) {
res.setHeader('content-type', 'application/javascript');

browserify({ debug: true })
.transform(babelify.configure({
presets: ["react", "es2015"],
compact: false
}))
.require("./app.js", { entry: true })
browserify("./app.js")
.transform("babelify", {presets: ["es2015", "react"]})
.bundle()
.pipe(res);
});
Expand Down
12 changes: 3 additions & 9 deletions exercises/isomorphic/problem.ko.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ var babelify = require("babelify");
그런 다음 `babel/register`를 `require`하고 있는 구문 밑에 다음과 같이 `index.jsx`를 불러 오도록 추가해 주세요.

```
require('babel/register')({
ignore: false
});
require('babel/register');

var TodoBox = require('./views/index.jsx');
```
Expand All @@ -65,12 +63,8 @@ var TodoBox = require('./views/index.jsx');
app.use('/bundle.js', function (req, res) {
res.setHeader('content-type', 'application/javascript');

browserify({ debug: true })
.transform(babelify.configure({
presets: ["react", "es2015"],
compact: false
}))
.require("./app.js", { entry: true })
browserify("./app.js")
.transform("babelify", {presets: ["es2015", "react"]})
.bundle()
.pipe(res);
});
Expand Down
12 changes: 3 additions & 9 deletions exercises/isomorphic/problem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ var babelify = require("babelify");
次に `babel/register` を `require` している文の下に以下のように `index.jsx` を読み込む処理を1行追加してください。

```
require('babel/register')({
ignore: false
});
require('babel/register');

var TodoBox = require('./views/index.jsx');
```
Expand All @@ -65,12 +63,8 @@ var TodoBox = require('./views/index.jsx');
app.use('/bundle.js', function (req, res) {
res.setHeader('content-type', 'application/javascript');

browserify({ debug: true })
.transform(babelify.configure({
presets: ["react", "es2015"],
compact: false
}))
.require("./app.js", { entry: true })
browserify("./app.js")
.transform("babelify", {presets: ["es2015", "react"]})
.bundle()
.pipe(res);
});
Expand Down
12 changes: 3 additions & 9 deletions exercises/isomorphic/solution/solution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ app.set('view engine', 'jsx');
app.set('views', __dirname + '/views');
app.engine('jsx', require('express-react-views').createEngine({transformViews: false}));

require('babel/register')({
ignore: false
});
require('babel/register');

var TodoBox = require('./views/index.jsx');

Expand All @@ -30,12 +28,8 @@ var data = [
app.use('/bundle.js', function (req, res) {
res.setHeader('content-type', 'application/javascript');

browserify({debug: true})
.transform(babelify.configure({
presets: ["react", "es2015"],
compact: false
}))
.require("isomorphic/solution/app.js", {entry: true})
browserify("./app.js")
.transform("babelify", {presets: ["es2015", "react"]})
.bundle()
.pipe(res);
});
Expand Down