Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Replace "With" should always end with slash? #115

Open
widoz opened this issue Dec 20, 2017 · 2 comments
Open

Domain Replace "With" should always end with slash? #115

widoz opened this issue Dec 20, 2017 · 2 comments

Comments

@widoz
Copy link
Contributor

widoz commented Dec 20, 2017

Trying to make a replacement like:

Search For: http://localhost/wp/search-and-replace/
Replace With: http://localhost/wp/search-and-replace

I get correctly a new domain url but without slash the url become something like:
http://localhost/wp/search-and-replacewp-content/...

@widoz widoz changed the title Domain Replace With should always end with slash? Domain Replace "With" should always end with slash? Jan 9, 2018
@bueltge bueltge added this to the 3.2.0 milestone Oct 26, 2018
@bvdv
Copy link
Contributor

bvdv commented Nov 17, 2018

If I understand correctly, S&R plugin should replace strictly "Search for:" to "Replace with:". It is mean Domain Replace "With" should be filled strictly that user want to get, so slash is necessary. This question will be very useful for documentation as example for avoiding problems.

@bueltge
Copy link
Contributor

bueltge commented Nov 18, 2018

Right, the function should do what the user add as input. It is in the responsibility of the user. Currently was the old idea to help them.

bvdv added a commit to bvdv/search-and-replace that referenced this issue Nov 22, 2018
Commit related to wp-media#115 
adding this question to the documentation as example how to do replace for avoiding problems.
bvdv added a commit to bvdv/search-and-replace that referenced this issue Nov 23, 2018
Pull request related to wp-media#115,
adding example to the readme.txt as example how to do replace for avoiding problems.
@bueltge bueltge removed this from the 3.2.0 milestone Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants