-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Tailwind #44
Conversation
I don't think I want to add another css lib since we use bootstrap currently and it has utility classes just like this. |
@@ -29,7 +24,7 @@ export function Header({selectedTheme, onClick}: HeaderProps) { | |||
|
|||
return ( | |||
<div className="d-flex justify-content-center"> | |||
<img style={logoStyle} src={logo} onClick={onClick} alt="logo" /> | |||
<img className="cursor-pointer h-[250px]" src={logo} onClick={onClick} alt="logo" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do the cursor with existing bootsrap. https://getbootstrap.com/docs/4.5/content/reboot/#pointers-on-buttons
Not sure about pixel height though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell you can only do percentages with bootstrap. Can't specify pixels
https://getbootstrap.com/docs/5.0/utilities/sizing/#utilities-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, looks like it
@@ -7,12 +7,11 @@ interface InputProps { | |||
|
|||
function Input({label, placeholder, value, onInput}: InputProps) { | |||
return ( | |||
<div style={{width: '100%'}}> | |||
<div className="w-[100%]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<label className="form-label">{label}</label> | ||
<div style={{borderRadius: '20px'}} className="shadow-sm"> | ||
<div className="shadow-sm rounded-full"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -204,7 +195,7 @@ function Goals() { | |||
<br></br> | |||
|
|||
<div className="d-flex"> | |||
<div className="flex-grow-1" style={{flexBasis: '0'}}> | |||
<div className="flex-grow-1 basis-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not look like bootstrap has a thing for this
Yeah I don't know @astone123. It seems there are a few things that tailwind can do that bootstrap cannot. Still not sure if we want to mix these together. |
@wweitzel okay I guess we should stick to bootstrap |
yeah i guess. im not married to bootstrap at all. just don't want two css libs mixing in a tiny project like this |
This PR adds Tailwind CSS so that we can use the utility classes that it provides. It also refactors the use of all
style
props to use Tailwind classes instead.