Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device isn't always the Source in the WRP #222

Closed
kristinapathak opened this issue Jun 12, 2020 · 2 comments
Closed

Device isn't always the Source in the WRP #222

kristinapathak opened this issue Jun 12, 2020 · 2 comments
Labels
wontfix
Projects
XMiDT

Comments

@kristinapathak
Copy link
Contributor

caduceus/outboundSender.go

Line 391 in b2866f4

if deviceRegex.MatchString(msg.Source) {

Now that Talaria creates a few wrp simple events, this check could filter them out if a webhook is registered for specific devices.
@kristinapathak kristinapathak added this to New issues in XMiDT Jun 12, 2020
@kristinapathak
Copy link
Contributor Author

There is a similar issue on this line:

caduceus/outboundSender.go

Line 582 in 453f141

id, _ := device.ParseID(msg.Source)

@kristinapathak kristinapathak mentioned this issue Jul 29, 2020
Closed
@kristinapathak kristinapathak added wontfix and removed bug labels Aug 6, 2020
@kristinapathak
Copy link
Contributor Author

Closing this in favor of the changes from the discussion related to #229

XMiDT automation moved this from New issues to Done Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
XMiDT
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added configurable device id parsing xmidt-org/caduceus
1 participant
@kristinapathak