Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTextview fixed draw on scroll introduced a bug (beta branch) #29

Open
GaNacereddine opened this issue Sep 30, 2020 · 1 comment
Open

Comments

@GaNacereddine
Copy link

in commit c8d1815 titled "fix Draw TTextView error while scrolling", where these changes are made

-- if Assigned(FScrollV) and (FCanScrollV) then begin
++ if Assigned(FScrollV) and (FCanScrollV) and (ScrollValueV < 1) then begin

this is supposed to fix some scrolling error (I'm interested to know what it is), How ever in one of my tests this does the opposite.

my View port size is 418 and my max content size is 3257 my max offset is 2839,

the bug I'm having because of your change is whenever ScrollValueV is 1 the TTextView draws the beginning of the long text I have, but the scroll bar is at the end (2839).

if I remove the change you made, the scrolling is right, but I do not know what that change fixes.

Note: this might be related, I'm using an HTML text in English so #25 might be the source of the problem.

@KngStr
Copy link
Collaborator

KngStr commented Oct 6, 2020

This is the test demo.
Run in Android, try to scroll to the end of the text, then you will found textview is shaking.

意帆.TextView滚动问题.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants