Skip to content
This repository has been archived by the owner on Jan 27, 2019. It is now read-only.

Enhancement of the Project #667

Open
debpedrano opened this issue Jun 23, 2018 · 30 comments
Open

Enhancement of the Project #667

debpedrano opened this issue Jun 23, 2018 · 30 comments

Comments

@debpedrano
Copy link

Greetings PO

I would like to submit a logo design for your project, is there any chance I can contribute ?

@shytikov
Copy link

shytikov commented Jul 9, 2018

Just learned that project is abandoned. I have forked and so far interested to merge all pull requests to it (I need it for my other projects). If you would like to participate we can combine our efforts.

@debpedrano
Copy link
Author

@shytikov I would love to work with you :) two idea is better than one, so it is not a problem

@shytikov
Copy link

My plan is to merge all pull-request that are pending, compile the code with most recent dependencies and put it to NuGet.

If everything will went well with that, I would be logical to use renewed logo that you will provide.

@debpedrano
Copy link
Author

I believe in you, i know you can do those works. Just enjoy working @shytikov , i will work on the logo and banner part.

@mkaring
Copy link

mkaring commented Jul 11, 2018

@shytikov I already started basically what you want to do as well. Checkout my fork. I also merged some of the pull requests already and fixed a few things of my own.

@debpedrano
Copy link
Author

great, @shytikov someone is helping you to make the project better. awesome work @mkaring !

@shytikov
Copy link

Superb! I can abandon my fork then and continue work on yours instead!

@alexmurari
Copy link

@mkaring That´s great. I will keep looking into your fork too.

@debpedrano
Copy link
Author

@shytikov if you have any desired design for the project, feel free to tell me. I have lots of designs on my mind, but your perspective for the design is important.

image

@bprg
Copy link

bprg commented Jul 13, 2018

@mkaring I tried Compressor fail to compress file.

[ERROR] Unknown error occurred.
Exception: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary2.get_Item(TKey key) at Confuser.Protections.Compress.ExtractPhase.ResourceRecorder.WriterEvent(Object sender, ModuleWriterEventArgs e) at dnlib.DotNet.Writer.EventHandler21.Invoke(Object sender, TEventArgs e)
at dnlib.DotNet.Writer.ModuleWriterOptionsBase.RaiseEvent(Object sender, ModuleWriterEventArgs e)
at dnlib.DotNet.Writer.ModuleWriterBase.OnWriterEvent(ModuleWriterEvent evt)
at dnlib.DotNet.Writer.ModuleWriterBase.Metadata_MetadataEvent(Object sender, MetadataWriterEventArgs e)
at dnlib.DotNet.Writer.Metadata.OnMetadataEvent(MetadataEvent evt)
at dnlib.DotNet.Writer.Metadata.Create()
at dnlib.DotNet.Writer.Metadata.CreateTables()
at dnlib.DotNet.Writer.ModuleWriter.WriteImpl()
at dnlib.DotNet.Writer.ModuleWriterBase.Write(Stream dest)
at dnlib.DotNet.ModuleDef.Write(Stream dest, ModuleWriterOptions options)
at Confuser.Core.ConfuserEngine.WriteModule(ConfuserContext context)
at Confuser.Core.ProtectionPipeline.ExecuteStage(PipelineStage stage, Action1 func, Func1 targets, ConfuserContext context)
at Confuser.Core.ConfuserEngine.RunPipeline(ProtectionPipeline pipeline, ConfuserContext context)
at Confuser.Core.ConfuserEngine.RunInternal(ConfuserParameters parameters, CancellationToken token)

@XenocodeRCE
Copy link
Contributor

@bprg does it work with ConfuserEX 1.0.0 ?

I'm revamping the project step after step here : https://github.com/XenocodeRCE/neo-ConfuserEx

@bprg
Copy link

bprg commented Jul 13, 2018

does it work with ConfuserEX 1.0.0 ?

Yes works properly, @mkaring ported to new version dnlib that's why it does not work properly.

@XenocodeRCE
Copy link
Contributor

@bprg Ok, I see, thanks for letting me know 👍

There is 0 valid argument as far as obfuscation is concerned to move to the newer version of dnlib however.

@mkaring
Copy link

mkaring commented Jul 13, 2018

The reason I ported to the new version is that the new version of dnlib supports the portable format of the pdb files. The current version does not.

@mkaring
Copy link

mkaring commented Jul 13, 2018

@bprg I found the possible reason for the problem. Is there any chance you can share the assembly you tried to compress with me? There are multiple reasons why this could go wrong. I want to ensure that I do not miss anything.

@mkaring
Copy link

mkaring commented Jul 13, 2018

@bprg I fixed the problem based on my tests. Would be great if you could test it again yourself. If the issue is not resolved, it would be nice if you could add the issue to my fork, as the version in this repository is not affected by the issue and I don't want to clutter this issue. 😉

@alexmurari
Copy link

@mkaring The issue tab of your repository is not enabled.

@mkaring
Copy link

mkaring commented Jul 13, 2018

@MurariAlex Fixed that.

@bprg
Copy link

bprg commented Jul 14, 2018

@mkaring Thank you, Now works properly.

@0xd4d
Copy link

0xd4d commented Jul 19, 2018

Two forks already by @XenocodeRCE and @mkaring , great but I think it would be better if they were merged. It's more likely that it will survive.

@XenocodeRCE
Copy link
Contributor

@0xd4d @mkaring fork uses latest dnlib version which I can't bear (sorry). I'll stick with the classic and continue on my side following latest Ki's recommendations.

@alexmurari
Copy link

@0xd4d @XenocodeRCE @mkaring Apart from the portable pdb compatibility, there is any other benefit in using the latest version of dnlib? Maybe bug fixes or a more stable assembly writing process or framework compatibility? If there´s not, maybe @mkaring can push his stuuf into @XenocodeRCE fork without the latest dnlib stuff, I saw that he made some improvements in the analyzers that can be useful.

@0xd4d
Copy link

0xd4d commented Jul 19, 2018

@MurariAlex Have a look in the git history, the dnlib used by ConfuserEx is at least two years old.

It's more important to try to use just one fork since more forks = more likely each fork will die.

@XenocodeRCE
Copy link
Contributor

@0xd4d I prefer epistemic diversity 🍷

@mkaring
Copy link

mkaring commented Jul 20, 2018

I am currently working on merging the updates done by @XenocodeRCE into my branch. There are just the few problems with it and I was able to sort most of them out. The last remaining issue is that the compressor does not work correctly anymore. I update the repository once I sorted this issue out. I don't want to push a state that is broken.

@XenocodeRCE
Copy link
Contributor

@mkaring current branches works flowlessly for me ?

@debpedrano
Copy link
Author

hello @everyone , is there any possible my logo will be merge on this project ?

@XenocodeRCE
Copy link
Contributor

@debpedrano if you give authorisation I can use it. But it is not possible on this repo because owner leaved.

@mkaring
Copy link

mkaring commented Jul 22, 2018

@debpedrano I'll gladly use it once I rework the UI. Do you happen to have those logos as SVG images? Would be great to ensure that the UI scales properly on high-res monitors.

@debpedrano
Copy link
Author

@XenocodeRCE @mkaring sure, you can freely use my logo . just tell me what sizes you need, or maybe the svg file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants