Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code of GCN-S part #2

Open
LZDSJTU opened this issue May 5, 2019 · 21 comments
Open

Code of GCN-S part #2

LZDSJTU opened this issue May 5, 2019 · 21 comments

Comments

@LZDSJTU
Copy link

LZDSJTU commented May 5, 2019

Hello, I saw that you will open the training code in late May. I want to ask if you will open the code of GCN-S part at that time. Thank you.

@yl-1993
Copy link
Owner

yl-1993 commented May 5, 2019

@LZDSJTU We will try to release as much code as possible before the conference.

@LZDSJTU
Copy link
Author

LZDSJTU commented May 5, 2019

Thank you for your contribution.

Additionally, could you provide the list for splitting MS-Celeb-1M dataset?

@yl-1993
Copy link
Owner

yl-1993 commented May 5, 2019

@LZDSJTU The list has been uploaded to GoogleDrive and OneDrive. You can also find it in README of the dev branch.

@jxyecn
Copy link

jxyecn commented May 6, 2019

Hello, I saw you evaluated your method with YTF dataset, I wonder how to generate this dataset?
How to sample images from YTF's original video frames, can you provide more detailed information?

@yl-1993
Copy link
Owner

yl-1993 commented May 7, 2019

@jxyecn We use the frames extracted by YTF dataset. Checkout the second or third download link in YTB official page. Particularly, as stated in experimental settings, we use 14,653 frames for training and 140,629 frames for testing. The related data and pretrained model have been uploaded to GoogleDrive and OneDrive to reproduce the result. You can also find it in README of the dev branch.

@jxyecn
Copy link

jxyecn commented May 8, 2019

@yl-1993 Thanks for your reply

@CaiQiuYu
Copy link

CaiQiuYu commented May 21, 2019

@LZDSJTU We will try to release as much code as possible before the conference.
期待尽早开源GCN-S部分的代码,好像从论文上看,GCN-D+GCN-S性能提升比起只用GCN-D并不是很多么?@yl-1993

@yl-1993
Copy link
Owner

yl-1993 commented May 24, 2019

@CaiQiuYu GCN-S is devised to improve the precision of the proposals. Since the precision of clustering results after GCN-D is over 95, there is no much space for improvement. In ablation study, we show that GCN-S can be used as an independent module to combine with other methods.

@LZDSJTU
Copy link
Author

LZDSJTU commented Jun 3, 2019

Is there any news about publishing the training code?

@yl-1993
Copy link
Owner

yl-1993 commented Jun 10, 2019

@LZDSJTU Thanks a lot for checking our progress. The training code will be available after PR #6 is merged.

@AruniRC
Copy link

AruniRC commented Jul 18, 2019

Hi @yl-1993 , is there any plan of releasing the code of the GCN-S ?

@yl-1993
Copy link
Owner

yl-1993 commented Jul 20, 2019

@AruniRC Thanks for checking our progress. Since the difference between GCN-S and GCN-D is not very significant, the priority of cleaning GCN-S is lower than our other projects currently. Actually, the model of GCN-S is available at dsgcn model. By setting the reduce_method to no_pool and stage to seg, it becomes the GCN-S model. One missing thing is introducing random seed in data processor to decide the segmentation ground-truth, which can be implemented through writing a cluster_seg_processor as cluster_det_processor. It is always in our schedule and we will find some time to work on that.

@zsz00
Copy link

zsz00 commented Oct 17, 2019

Hi @yl-1993 , is there any plan of releasing the code of the GCN-S ?

@yl-1993
Copy link
Owner

yl-1993 commented Oct 17, 2019

@zsz00 Thanks for checking. I'm busy preparing a submission and currently may not have much time for this project. For those who want to have a try, I provide a code snippet for GCN-S. The snippet can not run directly, but includes the data processing and loss function used in GCN-S.

@zsz00
Copy link

zsz00 commented Oct 17, 2019

Thanks for your reply

@yl-1993
Copy link
Owner

yl-1993 commented Mar 24, 2020

Hi all, GCN-S will be available after PR #31 is merged.

@yl-1993
Copy link
Owner

yl-1993 commented Mar 31, 2020

GCN-S is available now. Feel free to have a try. @LZDSJTU @CaiQiuYu @AruniRC @zsz00

@linjiawen2019
Copy link

@yl-1993 Hello, I would like to ask some questions about testing GCN-S with my own dataset which has no id labels. There's something wrong when I run "test_cluster_seg_ms1m.py", it occurred an error that "TypeError: 'NoneType' object is not subscriptable " in cluster_seg_processor.py. Here the 'NoneType' object refers to dataset.idx2lb
When building processor for GCN-S, a function "build_graph" in class ClusterSegProcessor will compute labels for data, my question is how to compute labels when testing data have no labels (which means dataset.idx2lb is None)?
I'll appreciate it if you could answer my question!! Thank you!
image

@yl-1993
Copy link
Owner

yl-1993 commented May 7, 2020

@linjiawen2019 Thanks for reporting! We will fix it through PR #44.

@linjiawen2019
Copy link

@linjiawen2019 Thanks for reporting! We will fix it through PR #44.

Thank u so much!! Really helpful to me

@yl-1993
Copy link
Owner

yl-1993 commented May 8, 2020

@linjiawen2019 The PR is merged. Feel free to have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants