Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doclicense: jp/yen image file #57

Open
nbeisert opened this issue Jun 28, 2020 · 4 comments
Open

doclicense: jp/yen image file #57

nbeisert opened this issue Jun 28, 2020 · 4 comments

Comments

@nbeisert
Copy link

Version 2.0.1 2020-06-26 introduces yen currency modifier "-jp" in code, but a corresponding image file is missing in the package. Could this be added?

@ypid
Copy link
Owner

ypid commented Jun 28, 2020

I would like to – When you find them ;-)

Refer to the Makefile that is used to download and convert the images: https://github.com/ypid/latex-packages/blob/master/doclicense/images/Makefile

I source all the files from: https://mirrors.creativecommons.org/presskit/buttons/

A more end user website is: https://creativecommons.org/about/downloads

None of them have the images we are looking for. Feel free to raise this issue upstream (from https://creativecommons.org).

@ypid ypid added the upstream label Jun 28, 2020
@nbeisert
Copy link
Author

I see, too bad. Well. One might engineer an image by combining the ".eu.svg" files with the icon "nc-jp.svg": this would amount to replacing the data d="M 86.070369, ..." for id="path45" with d="M 86.070316,6.7450069 C 83.824944,4.5032585 81.078023,3.3823843 77.82593,3.3823843 c -3.211869,0 -5.930885,1.1208742 -8.155601,3.3626226 -2.284149,2.3196624 -3.425679,5.0640461 -3.425679,8.2338771 0,3.169468 1.14153,5.895371 3.425679,8.175895 2.282698,2.280524 5.001715,3.420605 8.155601,3.420605 3.193386,0 5.960963,-1.149865 8.302006,-3.449959 2.206597,-2.183766 3.309714,-4.899883 3.309714,-8.146541 0,-3.24702 -1.122686,-5.9917663 -3.367334,-8.2338771 z M 84.618217,21.61788 c -1.915959,1.894216 -4.170391,2.84078 -6.762571,2.84078 -2.593268,0 -4.828493,-0.937504 -6.705314,-2.812513 -1.877184,-1.873922 -2.815413,-4.096826 -2.815413,-6.667263 0,-0.988602 0.141695,-1.927193 0.421823,-2.818312 l 5.937045,2.64364 h -1.306418 v 1.805067 h 2.71648 l 0.265633,0.551197 v 0.874811 h -2.982113 v 1.804705 h 2.982113 v 2.621534 h 2.885716 v -2.621534 h 3.000957 v -1.668447 l 3.786257,1.686204 c -0.387758,0.630197 -0.862127,1.21727 -1.424195,1.760131 z m -2.668644,-3.582593 h -2.69365 v -0.874811 l 0.135896,-0.263821 z m 0.306944,-2.400838 V 14.804212 H 80.452174 L 83.396598,9.3795868 H 80.319177 L 78.291602,13.868882 77.215664,13.389801 75.362761,9.3795868 h -3.077059 l 1.277064,2.3838052 -3.829019,-1.705048 c 0.397905,-0.6309217 0.878435,-1.2332149 1.445214,-1.8057921 1.819201,-1.85544 4.044279,-2.78316 6.676685,-2.78316 2.630956,0 4.866543,0.92772 6.704951,2.78316 1.857614,1.8362331 2.786059,4.0779811 2.786059,6.7263321 0,0.980991 -0.123938,1.899289 -0.370001,2.756705 z". Same for all three NC buttons. I'm not sure you'd want to go that way, it's not official. But it'd do the trick... Anyway, thanks for your reply.

@ypid
Copy link
Owner

ypid commented Jun 28, 2020

I would encourage you to talk to the CC people. I am sure they could make this official and then it would be solved for all.

@ypid
Copy link
Owner

ypid commented Jul 23, 2020

I would encourage you to talk to the CC people.

I did that now for #58. Outcome: Except yen, which is half-supported, no plans exist to add more currencies. I did not get an answer on how I as downstream should handle this and if modified images could be included upstream. So I guess this lets me decide how to proceed.

For background, see #58. I will accept PR adding more currencies. Please follow #58 and make an effort to make a working PR.

@ypid ypid added help wanted and removed upstream labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants