Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleDetectorAggregator can not be used for novelty detection #16

Open
Paroag opened this issue May 15, 2023 · 0 comments
Open

SimpleDetectorAggregator can not be used for novelty detection #16

Paroag opened this issue May 15, 2023 · 0 comments

Comments

@Paroag
Copy link

Paroag commented May 15, 2023

Currently, the implementation of SimpleDetectorAggregator does not allow for novelty detection usages.

The method _create_scores(self, X) does apply standardization based on the tensor of scores X. The data evaluated for novelty detection are not transformed the same way as the data used to fit the SimpleDetectorAggregator, and thus the threshold defined at fitting can not be applied to determine wether or not the data is a novelty.

One notable consequence is that running SimpleDetectorAggregator(...).predict(X[0, :]) (novelty detection on a single point) will always output the a score of 0.

SimpleDetectorAggregator should instead keep the scalers used when fitting and use them to process the data when creating new scores. This would add support for novelty detection.

Let me know if I am missing something as I am new to combo. If some help is wanted, I might have bandwidth to contribute to this cool project !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant