From 177a9b937090a93aff3ad764a7cd1fb2ac1fb4b6 Mon Sep 17 00:00:00 2001 From: Paul Jaggi Date: Thu, 19 May 2022 14:34:07 -0400 Subject: [PATCH] fall thru to tcp/ip for any AF_UNIX/ipc error https://github.com/zeromq/pyzmq/issues/1505 a few Jupyter users have encountered an issue where there program ends after this assert: Bad file descriptor (C:\ci\zeromq_1602704446950\work\src\epoll.cpp:100) We found this happens for users that have a windows 10 build that supports AF_Unix sockets but does not for those who have older windows 10 builds. this change is to remove the preserved errno (which doesn't appear to be used/checked anywhere-hence the later assert/abort) and instead after cleanup try to use a tcp/ip socket. --- src/ip.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ip.cpp b/src/ip.cpp index a0fa6f286a..0b87e13aef 100644 --- a/src/ip.cpp +++ b/src/ip.cpp @@ -664,11 +664,10 @@ int zmq::make_fdpair (fd_t *r_, fd_t *w_) } filename.clear (); } - + /* errno = saved_errno; - return -1; - + */ try_tcpip: // try to fallback to TCP/IP // TODO: maybe remember this decision permanently?