Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http.put() should stream the content #651

Open
yegor256 opened this issue Dec 24, 2018 · 13 comments
Open

Http.put() should stream the content #651

yegor256 opened this issue Dec 24, 2018 · 13 comments
Labels

Comments

@yegor256
Copy link
Collaborator

yegor256 commented Dec 24, 2018

See the changes made in #650. Http.get_file() now reads the content from HTTP page and saves it to the file, without touching the memory (well, only in small chunks). We should do the same for Http.put(). At the moment we are using IO.read() in order to read the entire file into memory first. This is not effective. Let's stream.

@yegor256
Copy link
Collaborator Author

@emilianodellacasa can you take a look?

@emilianodellacasa
Copy link
Contributor

@yegor256 Sure, please assign these to me

@yegor256
Copy link
Collaborator Author

@0crat assign @emilianodellacasa

@0crat 0crat added the scope label Dec 25, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

@0crat assign @emilianodellacasa (here)

@yegor256 The job #651 assigned to @emilianodellacasa/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

Bug was reported, see §29: +15 point(s) just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Dec 30, 2018

@emilianodellacasa/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@emilianodellacasa
Copy link
Contributor

@0crat wait - going on vacation for a few days

@0crat
Copy link
Collaborator

0crat commented Dec 31, 2018

@0crat wait - going on vacation for a few days (here)

@emilianodellacasa The impediment for #651 was registered successfully by @emilianodellacasa/z

@yegor256
Copy link
Collaborator Author

yegor256 commented May 5, 2019

@0crat assign @v-kolesnikov

@0crat
Copy link
Collaborator

0crat commented May 5, 2019

@0crat assign @v-kolesnikov (here)

@yegor256 The job #651 assigned to @v-kolesnikov/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented May 5, 2019

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

@v-kolesnikov
Copy link

@yegor256 I sent #766 as a solution for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants