add aliases for date funcs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with jq, alias `todate` -> `todateiso8601` and `fromdate` -> `fromdateiso8601` closes 01mf02#58
|
forgot these in the original PR (#85) |
Some loss of precision when parsing ISO-8601 timestamp with fractional seconds. Hopefully the test isn't too flaky
01mf02
reviewed
Jul 17, 2023
Comment on lines
+132
to
+134
| # Date | ||
| def todate: todateiso8601; | ||
| def fromdate: fromdateiso8601; |
There was a problem hiding this comment.
I really like you how respect my "maximum overlap" formatting style. Thanks a lot for your care to detail!
There was a problem hiding this comment.
It shows that you have studied what was there, you understood the principle behind it, and that you have adapted to it so your addition fits in nicely. I cannot emphasise enough how I appreciate this mindset of yours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with jq, alias
todate->todateiso8601and
fromdate->fromdateiso8601closes #58