Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutral Apocalypse (Role Base) - For v2.1.0 #815

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

MargaretTheFool
Copy link
Contributor

@MargaretTheFool MargaretTheFool commented Apr 11, 2024

#637 but updated
every NA can only be set once now
fixed Jailer typo so it actually can exe NEs

Soul Collector's collecting souls seems to not work, i dont think this is a problem that i caused
every NA can only be set once now
fixed Jailer typo so it actually can exe NCs
@Tommy-XL Tommy-XL added the Improve Role/Add-on Improvements or additions to documentation label Apr 12, 2024
@Tommy-XL Tommy-XL marked this pull request as draft April 12, 2024 00:14
@MargaretTheFool
Copy link
Contributor Author

MargaretTheFool commented Apr 14, 2024

there is a bug with passive souls where soul collector will be 1/1 in the meeting from gaining passive soul, and then when the meeting ends it just wins from Armageddon because it immediately turns into Death
I'm unsure how to fix this, this whole thing needs more testing in general

I also need ideas on what to do with Famine after it starves everyone without Bread, but that's more of a later issue
Also I need to be informed of what roles need to add settings for NA's

causes too many issues, it can call a meeting during the ejection screen and that will just mess with every client that isnt the host
if it could be implemented where it doesnt, then it could be readded, but i have no idea how to do that
apparently its in use lol
@Ultradragon005
Copy link
Contributor

image

@MargaretTheFool
Copy link
Contributor Author

alright everything should be updated and fixed, however there is this issue where automated messages from the host show blank to any other player that isn't the host, and the host's name shows as Player to vanilla clients and just doesn't show up to modded clients in the lobby

@Tommy-XL
Copy link
Collaborator

Tommy-XL commented May 5, 2024

Since they are theoretically neutral killers that continue the game, you also need add check in AntiBlackout.CheckBlackOut()

image

plaguebearer doesn't show up when doing CustomRoleManager.GetNormalOptions(Custom_RoleType.NeutralApocalypse).ForEach(r => r.SetupCustomOption()); so i went back to the previous option style for NA's so that they can be alphabetized
needs to update FamineInfoLong
and find out why OnCheckForEndVoting doesn't work for ANY role anymore
@Tommy-XL
Copy link
Collaborator

image

@Ultradragon005
Copy link
Contributor

Ultradragon005 commented May 22, 2024

Marg RN
image

@Tommy-XL Tommy-XL marked this pull request as draft May 25, 2024 17:12
@Tommy-XL Tommy-XL changed the title Neutral Apocalypse (Role Base) Neutral Apocalypse (Role Base) - For v2.1.0 May 25, 2024
@Ultradragon005
Copy link
Contributor

it's missing some galvanized steel and metal screws from your aunt https://www.youtube.com/watch?v=JQPPkID4c-g

@Tommy-XL Tommy-XL changed the base branch from RoleBase to main June 9, 2024 03:24
@Ultradragon005
Copy link
Contributor

@Pietrodjaowjao
Copy link
Contributor

I'm the best rapper in the world

@Pietrodjaowjao
Copy link
Contributor

image

@Ultradragon005
Copy link
Contributor

![image]
💀💀💀

@Ultradragon005
Copy link
Contributor

This branch has conflicts that must be resolved

@MargaretTheFool
Copy link
Contributor Author

nuh uh

because its no longer an impostor this line is useless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improve Role/Add-on Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants