forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pw2 #1
Open
As90909w
wants to merge
10,000
commits into
838:master
Choose a base branch
from
As90909w:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow pw2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#146475) flutter/engine@932c550...0226114 2024-04-09 [email protected] Use Impeller geometry classes in DLMatrixClipTracker (flutter/engine#51919) 2024-04-09 [email protected] Roll Dart SDK from 28b5735ad7dc to 78174b41ab0f (1 revision) (flutter/engine#51976) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146477) flutter/engine@0226114...5a824e2 2024-04-09 [email protected] [Impeller] ensure precision is matched between fragment and vertex stage for PowerVR GPU bug (flutter/engine#51974) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes [Some images show "404 - page not found" in Flutter `README.md` ](flutter#146419) These images had their sources updated in flutter/website#10336 ### Before ![Screenshot 2024-04-08 at 18 19 30](https://github.com/flutter/flutter/assets/48603081/56549762-b7c8-41a1-89db-cd45cd98b35a) ### After ![Screenshot 2024-04-08 at 18 19 23](https://github.com/flutter/flutter/assets/48603081/35d5772f-1144-4166-99cb-fded79550762)
…r#146508) flutter/packages@6b4d8b6...17f55d3 2024-04-09 [email protected] Release compileSdk changes (flutter/packages#6491) 2024-04-08 [email protected] [camera_android] Remove `TestUtils.java` (flutter/packages#6490) 2024-04-08 [email protected] Roll Flutter from 98d23f7 to 533d04d (12 revisions) (flutter/packages#6488) 2024-04-08 [email protected] [go_router_builder] Add `restorationScopeId` to `ShellRouteData` (flutter/packages#6238) 2024-04-08 [email protected] [go_router] Fixes deep links with no path (flutter/packages#6447) 2024-04-08 [email protected] [in_app_purchase] Convert Android data objects to Pigeon (flutter/packages#6453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
Skwasm tests are now running as `bringup: true` in postsubmit, but failing. Let's get them fixed.
Also move the vm service discovery logic into platform-specific implementation of `Device`s. This is to avoid having platform-specific code in attach.dart.
…lutter#146524) flutter/engine@5a824e2...5dca50d 2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete engine v1 android embedding (flutter#51229)" (flutter/engine#51996) 2024-04-09 [email protected] Delete engine v1 android embedding (flutter/engine#51229) 2024-04-09 [email protected] better output from engine layer unit test failures (flutter/engine#51975) 2024-04-09 [email protected] Revert "Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter#51980)" (flutter/engine#51990) 2024-04-09 [email protected] [skwasm] Reify the SkPicture pointer as the right type. (flutter/engine#51991) 2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter#51986)" (flutter/engine#51989) 2024-04-09 [email protected] Move the Dart SDK to //flutter/third_party/dart (flutter/engine#51917) 2024-04-09 [email protected] [macOS] Implement hit testing and handle platform view cursor changes (flutter/engine#43101) 2024-04-09 [email protected] Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter/engine#51986) 2024-04-09 [email protected] Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter/engine#51980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
## Description This PRs makes the label vertical position depend on visual density for filled text field. Previously, for M2 and M3, the label vertical offset was always the same (12 on M2, 8 and M3) despite different visual density configuration. This was noticable on desktop and can lead to weird rendering especially on M3 where line height makes the cursor taller. Screenshots for a filled text field: | | Before | After | |--------|--------|--------| |M3 macOs| ![image](https://github.com/flutter/flutter/assets/840911/bd9bdb6e-477c-4db0-ae8f-74e18d19f29e) | ![image](https://github.com/flutter/flutter/assets/840911/25e59c44-0139-4813-be28-472302d6970e) | |M2 macOs| ![image](https://github.com/flutter/flutter/assets/840911/1c52493b-b17b-407b-93cc-69120207b716) | ![image](https://github.com/flutter/flutter/assets/840911/1fc4a8b6-429b-476c-b5bf-ff2934bf5293) | </details> ## Related Issue Fixes flutter#141354 ## Tests Adds 2 tests, updates 2 tests.
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.2.0 to 4.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v4.3.0</h2> <h2>What's Changed</h2> <ul> <li>fix: automatically detect if using GitHub enterprise by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1356">codecov/codecov-action#1356</a></li> <li>build(deps-dev): bump typescript from 5.4.3 to 5.4.4 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1355">codecov/codecov-action#1355</a></li> <li>build(deps): bump github/codeql-action from 3.24.9 to 3.24.10 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1360">codecov/codecov-action#1360</a></li> <li>build(deps-dev): bump <code>@�typescript-eslint/eslint-plugin</code> from 7.5.0 to 7.6.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1364">codecov/codecov-action#1364</a></li> <li>build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.5.0 to 7.6.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1363">codecov/codecov-action#1363</a></li> <li>feat: add network params by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1365">codecov/codecov-action#1365</a></li> <li>build(deps): bump undici from 5.28.3 to 5.28.4 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1361">codecov/codecov-action#1361</a></li> <li>chore(release): v4.3.0 by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1366">codecov/codecov-action#1366</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.2.0...v4.3.0">https://github.com/codecov/codecov-action/compare/v4.2.0...v4.3.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-action/commit/84508663e988701840491b86de86b666e8a86bed"><code>8450866</code></a> chore(release): v4.3.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1366">#1366</a>)</li> <li><a href="https://github.com/codecov/codecov-action/commit/e8419092e9de1e2493563107cf52bfa83d9ae62f"><code>e841909</code></a> build(deps): bump undici from 5.28.3 to 5.28.4 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1361">#1361</a>)</li> <li><a href="https://github.com/codecov/codecov-action/commit/363a65ad481c04303701b094b4d2c113a65f5d3e"><code>363a65a</code></a> feat: add network params (<a href="https://redirect.github.com/codecov/codecov-action/issues/1365">#1365</a>)</li> <li><a href="https://github.com/codecov/codecov-action/commit/640b86a455d2fd2f6e7acbb9eb863bc9f4a51954"><code>640b86a</code></a> build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.5.0 to 7.6.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1363">#1363</a>)</li> <li><a href="https://github.com/codecov/codecov-action/commit/375c033fbe86348a044b3884012d849d84b90769"><code>375c033</code></a> build(deps-dev): bump <code>@�typescript-eslint/eslint-plugin</code> from 7.5.0 to 7.6.0 (#...</li> <li><a href="https://github.com/codecov/codecov-action/commit/d701256d7a115528200188787cd91ce87889775f"><code>d701256</code></a> build(deps): bump github/codeql-action from 3.24.9 to 3.24.10 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1360">#1360</a>)</li> <li><a href="https://github.com/codecov/codecov-action/commit/0bb547ab4974725a7d01e2ac18c843a6924c39f3"><code>0bb547a</code></a> build(deps-dev): bump typescript from 5.4.3 to 5.4.4 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1355">#1355</a>)</li> <li><a href="https://github.com/codecov/codecov-action/commit/55e8381a3e12db78da75715d4d60379adb17c4e6"><code>55e8381</code></a> fix: automatically detect if using GitHub enterprise (<a href="https://redirect.github.com/codecov/codecov-action/issues/1356">#1356</a>)</li> <li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/7afa10ed9b269c561c2336fd862446844e0cbf71...84508663e988701840491b86de86b666e8a86bed">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.2.0&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…lutter#146527) flutter/engine@5dca50d...e4e2748 2024-04-09 [email protected] Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998) 2024-04-09 [email protected] [Impeller] Remove StC flag. (flutter/engine#51992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146538) flutter/engine@e4e2748...eaf73cd 2024-04-09 [email protected] Update embedder example apps to run with the current engine tree (flutter/engine#51995) 2024-04-09 [email protected] [Impeller] Refactor KHR swapchains to make it easy to reuse backend agnostic components. (flutter/engine#52002) 2024-04-09 [email protected] Roll Skia from 74b0e26886f0 to 45eeeddb0074 (1 revision) (flutter/engine#52007) 2024-04-09 [email protected] Try postsubmit_overrides for one mac build (flutter/engine#51676) 2024-04-09 [email protected] [Impeller] Remove stencil clipping logic. (flutter/engine#51999) 2024-04-09 [email protected] Roll Skia from a86861d21ae1 to 74b0e26886f0 (2 revisions) (flutter/engine#52000) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146541) flutter/engine@eaf73cd...cee489a 2024-04-10 [email protected] Roll Skia from 45eeeddb0074 to 3e3f28d64b2b (1 revision) (flutter/engine#52010) 2024-04-09 [email protected] Roll Fuchsia Linux SDK from 82nvjI_UGVS8qYqyH... to imlnJ68ZziH-Lp2xk... (flutter/engine#52009) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 82nvjI_UGVS8 to imlnJ68ZziH- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#146575) flutter/packages@17f55d3...2c15d86 2024-04-10 [email protected] [in_app_purchase_android] Cleanup, create listener where it is used (flutter/packages#6489) 2024-04-09 [email protected] Roll Flutter from 533d04d to 4967a94 (12 revisions) (flutter/packages#6492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146577) flutter/engine@cee489a...0d5412d 2024-04-10 [email protected] Roll Skia from 89db27b5acb8 to 2135d686708b (1 revision) (flutter/engine#52016) 2024-04-10 [email protected] Roll Skia from 1ea5f3cd71cb to 89db27b5acb8 (2 revisions) (flutter/engine#52015) 2024-04-10 [email protected] Roll Skia from 14dd5528b318 to 1ea5f3cd71cb (1 revision) (flutter/engine#52014) 2024-04-10 [email protected] Add postsubmit overrides for mac builders. (flutter/engine#51385) 2024-04-10 [email protected] [Impeller] NumberNear implements precision-based comparisons (flutter/engine#52001) 2024-04-10 [email protected] Roll Skia from 3e3f28d64b2b to 14dd5528b318 (2 revisions) (flutter/engine#52011) 2024-04-10 [email protected] [Impeller] Use type safe masks for HardwareBufferUsage. (flutter/engine#52008) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Convert `ProjectMigration.run()` and `ProjectMigrator.migrate()` to be async. Needed for Swift Package Manager migration, which requires some async processes: flutter#146256
…lutter#146585) flutter/engine@0d5412d...077b742 2024-04-10 [email protected] Roll Skia from 2135d686708b to df6d08abb447 (1 revision) (flutter/engine#52017) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146591) flutter/engine@077b742...beee02b 2024-04-10 [email protected] Roll Dart SDK from 78174b41ab0f to 393a24d37b39 (8 revisions) (flutter/engine#52020) 2024-04-10 [email protected] Use RBE in mac builds in presubmit but not postsubmit (flutter/engine#52018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…146523) flutter/engine#51229 blocked [the roll](flutter#146522) and had to be reverted, which is a shame, but on the bright side it made it possible to point the framework at my removal pr, at the point of its merging the first time This fixes all errors that are fixable in the framework that would have blocked the roll. There are some that aren't fixable here (they need to be fixed in the engine)*, so I'll fix those in the engine but unfortunately I can't pick up another version here to re-test until I try to roll again ð��¢ *This category is: uses of plugins that in turn have a `registerWith`, that references the v1 embedding. The plan to fix these cases is to leave the interface that that method relies on around for now. See flutter/packages#6494 (comment) for details
…lutter#146605) flutter/engine@beee02b...91ba235 2024-04-10 [email protected] Adds iOS builds to local_engine.json (flutter/engine#52027) 2024-04-10 [email protected] Roll Skia from df6d08abb447 to 91e0c0f4bf41 (3 revisions) (flutter/engine#52026) 2024-04-10 [email protected] [Android] post image task to main handler. (flutter/engine#52025) 2024-04-10 [email protected] [et] Adds --lto flag to build. Plumbs verbose flag differently. (flutter/engine#52021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
…lutter#146607) flutter/engine@91ba235...6f8ee9f 2024-04-10 [email protected] Manual roll ICU from a622de35ac31 to bad7ddbf9213 (7 revisions) (flutter/engine#52031) 2024-04-10 [email protected] Enable gtest-parallel for Impeller unit tests (flutter/engine#52004) 2024-04-10 [email protected] Add additional dependencies to const_finder's pubspec.yaml (flutter/engine#52033) 2024-04-10 [email protected] Roll Skia from 91e0c0f4bf41 to 5bbca5a30653 (3 revisions) (flutter/engine#52032) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146609) flutter/engine@6f8ee9f...4e33a0b 2024-04-10 [email protected] Roll Skia from 5bbca5a30653 to fcb5c05acaf2 (1 revision) (flutter/engine#52036) 2024-04-10 [email protected] [Engine] allow --enable-asserts flag to be passed to dart vm in profile mode. (flutter/engine#52029) 2024-04-10 [email protected] Migrate FlutterRestorationPlugin, FlutterTextureRegistryRelay, FlutterScreenAndSceneIfLoaded to ARC (flutter/engine#51984) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146611) flutter/engine@4e33a0b...28ed190 2024-04-10 [email protected] Roll Dart SDK from 393a24d37b39 to f5ef31c467a5 (1 revision) (flutter/engine#52037) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146613) flutter/engine@28ed190...069e73e 2024-04-11 [email protected] Roll Fuchsia Linux SDK from imlnJ68ZziH-Lp2xk... to peYcbx9eguHcbhMP0... (flutter/engine#52043) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from imlnJ68ZziH- to peYcbx9eguHc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146617) flutter/engine@069e73e...e47dc9a 2024-04-11 [email protected] Roll Skia from fcb5c05acaf2 to cd47aa5d8d15 (1 revision) (flutter/engine#52044) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146618) flutter/engine@e47dc9a...e2a45bd 2024-04-11 [email protected] Roll Dart SDK from f5ef31c467a5 to 3d13dbfb3284 (2 revisions) (flutter/engine#52046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146619) flutter/engine@e2a45bd...fef8499 2024-04-11 [email protected] Roll Skia from cd47aa5d8d15 to 28579a88aa9c (1 revision) (flutter/engine#52045) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147235) flutter/engine@ffd3911...79f4995 2024-04-23 [email protected] [fuchsia] Update Fuchsia API version to 17 (flutter/engine#52266) 2024-04-23 [email protected] [skia] Remove no-op GN flag (flutter/engine#52121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#147240) flutter/packages@01a32c4...cf6d280 2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.2 to 4.3.3 (flutter/packages#6598) 2024-04-22 [email protected] [image_picker] Fix If imageToScale is nil, the app will crash (flutter#146682) (flutter/packages#6514) 2024-04-22 [email protected] Roll Flutter from 1a905d5 to 140edb9 (5 revisions) (flutter/packages#6594) 2024-04-22 [email protected] [pointer_interceptor_web] Remove semantic tests. (flutter/packages#6580) 2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/packages#6571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147241) flutter/engine@79f4995...f794e67 2024-04-23 [email protected] Roll Dart SDK from b340d0f393b6 to acd54f86bdbb (1 revision) (flutter/engine#52321) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…utter#146293) Based on issue flutter#144903, this pull request aims to bring the codebase more in line with the [Flutter repo style guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or--or--with-enum-values): > ### Avoid using `if` chains or `?:` or `==` with enum values
Fixes flutter#147189 This allows const `IconData` to fallback to the system font if `fontFamily` is not provided. A similar non-fatal error occurs when IconData specifies a font that is not included in the manifest, so I modeled after that error message: https://github.com/flutter/flutter/blob/b4121a1867a93e030377b3509147e7fdbf6517d5/packages/flutter_tools/lib/src/build_system/targets/icon_tree_shaker.dart#L122
This PR contributes to flutter#130459 ### Description - Adds `examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart` test
This PR fixes some typos and improves readability in the documentation for the Navigator and NavigatorObserver classes. </br>
This PR contributes to flutter#130459 ### Description - Adds `examples/api/test/widgets/implicit_animations/animated_align.0_test.dart` test
`StretchingOverscrollIndicator`'s controller does not have a minimum value for its animation duration. When the `OverscrollNotification`'s `velocity` is small enough (< `25`) the controller's `absorbImpact` method sets this animation duration to 0ms, making the animation appear frozen to the user. This PR sets a minimum animation duration of 50ms. Fixes flutter#146277 | Before | After | | --- | --- | | <video src="https://github.com/flutter/flutter/assets/82336674/8761f14e-d5a5-4a39-b8e7-9e77433ce2c6" width=250px />| <video src="https://github.com/flutter/flutter/assets/82336674/57b38448-29fb-41ad-a947-d7cf1c160ca3" width=250px /> |
…lutter#147248) flutter/engine@f794e67...066953b 2024-04-23 [email protected] Roll Skia from 0756b4606e6f to 21563606e32d (2 revisions) (flutter/engine#52325) 2024-04-23 [email protected] Roll Skia from a373bf46bffb to 0756b4606e6f (3 revisions) (flutter/engine#52323) 2024-04-23 [email protected] [Impeller] add test case for path that explicitly closes at origin. (flutter/engine#52314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…nTheme` from the chip property and `ChipThemeData` (flutter#146509) fixes [Provided delete icon overrides the default delete icon size](flutter#146404) fixes [Chips delete icon ignores `IconTheme` from `Chip.iconTheme` and `ChipThemeData.iconTheme`](flutter#146501) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData( chipTheme: const ChipThemeData( iconTheme: IconThemeData( color: Colors.red, ), ), ), home: Scaffold( body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ FilterChip( avatar: const Icon(Icons.favorite), onDeleted: () {}, label: const Text('Filter Chip'), onSelected: (value) {}, ), const SizedBox(height: 10), FilterChip( avatar: const Icon(Icons.favorite), // ignore: prefer_const_constructors deleteIcon: const Icon(Icons.delete), onDeleted: () {}, label: const Text('Filter Chip'), onSelected: (value) {}, ), ], ), ), ), ); } } ``` </details> ### Before ![Screenshot 2024-04-09 at 16 48 48](https://github.com/flutter/flutter/assets/48603081/79d14a63-3c24-4f3e-bda4-5de76b319160) ### After ![Screenshot 2024-04-09 at 16 48 31](https://github.com/flutter/flutter/assets/48603081/8d54373f-53f1-4908-bd9c-2ee351227f27)
Refactor the framework + test harness test suites in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing tests The refactor of both suites included in this PR because they both depended on util functions and variables that also needed to be refactored. Part of flutter#145482
…lutter#147255) flutter/engine@066953b...f23cc4d 2024-04-23 [email protected] [Impeller] Cleanup `PipelineVK::Create` (flutter/engine#52278) 2024-04-23 [email protected] Issue flutter#146080 : Fix for incorrect STB based atlas glyph scaling (flutter/engine#51882) 2024-04-23 [email protected] [Impeller] Do not call std::forward on the serialized arguments in the canvas recorder (flutter/engine#52307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR contributes to flutter#130459 ### Description - Adds `examples/api/test/widgets/focus_manager/focus_node.0_test.dart` test
…lutter#147258) flutter/engine@f23cc4d...b686508 2024-04-23 [email protected] Roll Fuchsia Linux SDK from L533ubzhjWwW7jxbc... to le_-uFgRD5DjvvqgL... (flutter/engine#52329) 2024-04-23 [email protected] [Impeller] only use framebuffer advanced blends if available. (flutter/engine#52284) 2024-04-23 [email protected] [Impeller] drawVertices uber shader. (flutter/engine#52315) 2024-04-23 [email protected] Roll Dart SDK from acd54f86bdbb to 6a670b60eb06 (1 revision) (flutter/engine#52327) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from L533ubzhjWwW to le_-uFgRD5Dj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147262) flutter/engine@b686508...303e718 2024-04-23 [email protected] Roll Skia from f9d6a2cf4179 to f09c6745031c (1 revision) (flutter/engine#52334) 2024-04-23 [email protected] [skwasm] Fix sampling options for low filter quality to match CanvasKit. (flutter/engine#52331) 2024-04-23 [email protected] [Impeller] Fix Vulkan validation error on latest MoltenVK. (flutter/engine#52332) 2024-04-23 [email protected] Roll Skia from 21563606e32d to f9d6a2cf4179 (1 revision) (flutter/engine#52330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…0962) This will add a new autovalidateMode to Form and FormField, based on issue flutter#40675.
) This PR contributes to flutter#130459 ### Description - Adds `examples/api/test/widgets/implicit_animations/sliver_animated_opacity.0_test.dart` test
…ragraph (flutter#146843) This PR removes unnecessary local variables and related comments in `Editable` and `RenderParagraph` as both now use another `TextPainter` instance for intrinsics cache. Test-exempt: minor refactor and comments.
…lutter#147264) flutter/engine@303e718...5f17a77 2024-04-23 [email protected] Roll Skia from f09c6745031c to cdede8e2e18b (1 revision) (flutter/engine#52335) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147266) flutter/engine@5f17a77...d56a231 2024-04-23 [email protected] Add containsCommand matcher (flutter/engine#52306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147267) flutter/engine@d56a231...9819627 2024-04-23 [email protected] Roll Dart SDK from 6a670b60eb06 to cf9144942ca1 (1 revision) (flutter/engine#52338) 2024-04-23 [email protected] [Impeller] Reland: Compute UVs in vertex stage. (flutter/engine#52303) 2024-04-23 [email protected] [Impeller] Add DriverInfoVK::IsEmulator and a log dumper for driver info. (flutter/engine#52337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147270) flutter/engine@9819627...7f89b43 2024-04-23 [email protected] [macOS] Disable FlutterEngineTest.BackgroundColor (flutter/engine#52341) 2024-04-23 [email protected] Roll Skia from cdede8e2e18b to e15464e6e982 (2 revisions) (flutter/engine#52344) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147272) flutter/engine@7f89b43...fcb1060 2024-04-23 [email protected] [et] Don't require the --verbose flag when requesting a ci/ build (flutter/engine#52339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147276) flutter/engine@fcb1060...d4f6338 2024-04-24 [email protected] [Impeller] delete unused geometry API. (flutter/engine#52347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147281) flutter/engine@d4f6338...3d91141 2024-04-24 [email protected] Roll Dart SDK from cf9144942ca1 to 60cb97ab64e6 (1 revision) (flutter/engine#52351) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#147293) flutter/engine@3d91141...b5d5832 2024-04-24 [email protected] Roll Dart SDK from 60cb97ab64e6 to 5227dc5103f6 (1 revision) (flutter/engine#52356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…46685) fixes [Add missing `overlayColor` property in `styleFrom` methods](flutter#146636) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; enum Sizes { extraSmall, small, medium, large, extraLarge } void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, home: Scaffold( body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: <Widget>[ Text('styleFrom(overlayColor: Colors.red)', style: Theme.of(context).textTheme.titleLarge), TextButton( style: TextButton.styleFrom(overlayColor: Colors.red), onPressed: () {}, child: const Text('TextButton'), ), IconButton( style: IconButton.styleFrom( overlayColor: Colors.red, ), onPressed: () {}, icon: const Icon(Icons.add), ), MenuBar( children: [ MenuItemButton( style: MenuItemButton.styleFrom(overlayColor: Colors.red), child: const Text('MenuItemButton'), onPressed: () {}, ), SubmenuButton( style: SubmenuButton.styleFrom(overlayColor: Colors.red), menuChildren: [ MenuItemButton( child: const Text('MenuItemButton'), onPressed: () {}, ), ], child: const Text('SubmenuButton'), ), ], ), SegmentedButton<Sizes>( style: SegmentedButton.styleFrom(overlayColor: Colors.red), segments: const <ButtonSegment<Sizes>>[ ButtonSegment<Sizes>( value: Sizes.extraSmall, label: Text('XS')), ButtonSegment<Sizes>(value: Sizes.small, label: Text('S')), ButtonSegment<Sizes>(value: Sizes.medium, label: Text('M')), ButtonSegment<Sizes>( value: Sizes.large, label: Text('L'), ), ButtonSegment<Sizes>( value: Sizes.extraLarge, label: Text('XL')), ], selected: const {Sizes.medium}, onSelectionChanged: (Set<Sizes> newSelection) {}, multiSelectionEnabled: true, ), ], ), ), ), ); } } ``` </details> ### Preview ![ScreenRecording2024-04-12at15 25 58-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/89b9638d-f369-4ef1-b501-17c9c74b2541)
can u merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have agreed to evrything.
So ]doc