Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto route polish #62

Merged
merged 6 commits into from
Apr 2, 2024
Merged

auto route polish #62

merged 6 commits into from
Apr 2, 2024

Conversation

shunjizhan
Copy link
Collaborator

@shunjizhan shunjizhan commented Mar 29, 2024

Change

  • added request params and other info to routeStatus for potential debugging convenience
  • added optional timeout param to /routeStatus, to be more flexible
  • added optional destAddr param to /routeStatus, so if user closes page and come back, UI can query user's recent route requests, and resume progress page (this is for frontend UX only, routing will continue in backend anyways)
  • optimized tracker cleanup. It's not a good practice to have too many timeouts pending for 1 week, instead we can check tracker size, and do the cleanup when it reaches size limit
  • moved route homa tests to it's only file

Test

tested locally, auto routing still works, and new param also works

@shunjizhan shunjizhan requested a review from xlc April 1, 2024 04:05
@shunjizhan shunjizhan marked this pull request as ready for review April 1, 2024 04:05
@shunjizhan shunjizhan merged commit ccd1354 into master Apr 2, 2024
1 check failed
@shunjizhan shunjizhan deleted the auto-route-polish branch April 2, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants