Sat/master #74
Open
Sat/master #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #create instance variable for balance? | ||
| def initialize (id, balance, open_date) | ||
| if balance < 0 |
There was a problem hiding this comment.
Watch out for your indentation here - you don't need an additional indent when you start your if statement, only inside the block of it
|
Nice job with your account functionality. I think that your owner class could use a bit more work since I'm not sure the way you've set up inheritance is the way you want/intend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most recent versions of Bank Account project. I still have some work to do in owner.rb file to be able to successfully create a new instance of an existing owner hash.