Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List “1Host (Pro)” #50

Open
ghost opened this issue May 29, 2022 · 12 comments
Open

Add List “1Host (Pro)” #50

ghost opened this issue May 29, 2022 · 12 comments
Labels
in progress The request is accepted, but it requires some additional work on our side

Comments

@ghost
Copy link

ghost commented May 29, 2022

Please add list “1Host (Pro)”

https://badmojr.github.io/1Hosts/

@badmojr
Copy link

badmojr commented Jun 4, 2022

Here's what Reddit has to say about Pro: https://socialgrep.com/search?query=1hosts%2Cpro

@badmojr
Copy link

badmojr commented Jun 30, 2022

@devipasigner
Copy link

+1 I would really like to see this list added. It is very well maintained and been my daily driver for a while now.

@ameshkov ameshkov added the help wanted Extra attention is needed label Dec 5, 2022
@ameshkov
Copy link
Member

ameshkov commented Dec 5, 2022

We're a bit afraid that the Pro version completely breaks Facebook apps. There's no such concern with the Lite version and so it was included without questions.

With Pro we'll need to indicate in the UI that this blocklist will break lots of popular stuff.

@badmojr
Copy link

badmojr commented Dec 5, 2022

will break lots of popular stuff.

Really?

@ameshkov
Copy link
Member

ameshkov commented Dec 6, 2022

@badmojr well, Facebook apps are pretty popular so yeah, breaking them = breaking popular staff.

The point is that people who should know about this beforehand. Currently, the UI in both AG DNS and AG Home does not indicate any potential issue the user may face after enabling the blocklist.

@ameshkov ameshkov mentioned this issue Dec 6, 2022
4 tasks
@ameshkov ameshkov added in progress The request is accepted, but it requires some additional work on our side and removed help wanted Extra attention is needed labels Dec 6, 2022
@badmojr
Copy link

badmojr commented Dec 6, 2022

@badmojr well, Facebook apps are pretty popular so yeah, breaking them = breaking popular staff.

The point is that people who should know about this beforehand. Currently, the UI in both AG DNS and AG Home does not indicate any potential issue the user may face after enabling the blocklist.

I believe if one log in to the apps prior to enabling the Pro version, they should find the apps to work just fine.

@ameshkov
Copy link
Member

ameshkov commented Dec 6, 2022

As I recall from blocking graph.facebook.com, that's not the case. At some point the app will need to connect there again.

But don't get me wrong, I don't propose unblocking it or changing anything in the list. Blocking graph.facebook.com makes sense, it is used to load third-party ads and track people by tons of other apps. What I am saying is just that we at AdGuard should do some improvements to our products UI before adding this blocklist.

@hagezi
Copy link
Contributor

hagezi commented Dec 6, 2022

@badmojr 1Hosts lists are effective as hell. They are one of the must have lists for me. The Lite version for everyone and the Pro if it may be a little more aggressive. Yes there are some domains that restrict functions, but what you need to whitelist is relatively manageable.

I agree with @ameshkov, in AdGuardDNS should be introduced a category "aggressive" to point out to the user that these are not lists that you just take in if you do not know what you are doing.

I would appreciate it very much if the Pro is included.

@kishore-manoharan
Copy link

Please add "1 Host Pro", even though it affects FB or some other UI, it's the user's own desire to turn it on. And anytime they can turn off them if required.

@brokoler
Copy link

brokoler commented Sep 2, 2023

I stumbled upon this issue since I also miss more restrictive filter lists:
#335

I'm really embarassed now to see this issue here, how is it even possible this issue is open for more than one year and nothing happened with it? It's a filter list to add, nothing more. Instead this issue was completely ignored now with the excuse that it might produce too many false positives. Experienced people choose restrictive lists on purpose and know how to whitelist false positives, either via allow lists or manually.

To me it seems like more restrictive blocklists are missing on purpose, why was only HaGeZi's Normal list and 1Hosts Lite and Mini added for example? I would never choose them personally if I want to reduce tracking. Please @ameshkov let us know if more restrictive lists will be supported in future. If they won't be supported I'm switching back to NextDNS and I'm sure it's a showstopper for most people new to Adguard DNS.

Probably a feature that allows to add custom blocklist URLs can be added like in Adguard Home to let the user decide?

@wealstarrr
Copy link

Shaking my head that after two years, it's still not implemented. @brokoler yeah, if this doesn't happen, I'll move to rethinkDNS

@Sergey-Lyapin Sergey-Lyapin mentioned this issue Jun 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress The request is accepted, but it requires some additional work on our side
Projects
None yet
Development

No branches or pull requests

7 participants