Fixed issue for order status pre-authorized state configuration #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
|
Please approve workflows |
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
|
@candemiralp please check this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the Webhook Helper[adyen/module-payment/Helper/Webhook.php] file, we can assign states if order is in pre-authorized condition.
But when we create new order status "adyen_authorized" [ref. from adyen-magento2/Model/Config/Source/PreAuthorized.php], and assign this status in Adyen configuration, it's not working.
When the order is Authorized, Even if we have assigned new status in configuration, it will show order in "Pending" status only. The reason is, below function only grab the first item from the assigned Statuses. [file ref. vendor/adyen/module-payment/Helper/Order.php]
So As solution, I switched the sequence in Webhook Helper[adyen/module-payment/Helper/Webhook.php] file to pick "adyen_authorized" first and then check for "NEW" status. See updated file below:
Tested scenarios
Fixes
There is no such issue reported.