Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8518] Unset amqp in config to use default queue connection #2654

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

factorin-j
Copy link
Contributor

Description

  • remove amqp in queue xml config to use Magento's default (db) connection if amqp service is not installed.
  • include additional admin message when using 'queue' notification processing
  • add unit tests

Tested scenarios

  • Tested using 2 Magento setups:
    • bin/magento setup:install with opensearch/elasticsearch only
    • bin/magento setup:install with --amqp-* options included (RabbitMQ installed).
  • Unit test output:
docker compose exec -it php vendor/bin/phpunit -c dev/tests/unit/phpunit.xml app/code/Adyen/Payment/Test/Unit/Model/Queue/
PHPUnit 9.5.24 #StandWithUkraine

...                                                                                                                                                                                                                                                3 / 3 (100%)

Time: 00:00.047, Memory: 22.00 MB

OK (3 tests, 8 assertions)

Fixes #2031

- remove amqp in queue xml config to use default (db) if amqp service is not installed.
- include additional admin message when using 'queue' notification processing
- add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant