Fix PayPal popup infinite loading spinner if T&Cs are not checked #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checked If the checkout form is not valid and the user clicks on the PayPal button, the popup will be opened with an infinite loading spinner. Event if the customer closes the popup, checks the checkbox and clicks again on the PayPal button, the popup will not work anymore, until the page is reloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
onInitandonClickfunctions to the configuration object in order to maange the PayPal Buttons state (enabled / disabled) depending on the checkout agreements checkbox state.Without these functions, if the form is not valid (checkbox unchecked) and the user clicks on the PayPal button, the popup will be opened with an infinite loading spinner, and even if the customer closes the popup, checks the checkbox and clicks again on the PayPal button, the popup will not work anymore, until the page is reloaded.
Tested scenarios
Expected result
Fixes #2613