Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of duplicate /details calls in Adyen payment return controller #2668

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve handling of duplicate /details calls in Adyen payment return controller #2668

wants to merge 3 commits into from
+74 −89

Conversation

raoulritter
Copy link
Contributor

@raoulritter raoulritter commented Jul 2, 2024 •
edited
Loading

Description

Update validateRedirectResponse to check for duplicates after paymentsDetails call to prevent duplicate redirects from effecting comment history.

Tested scenarios

  • Successfull details call.
  • Duplicate details call
  • Unsuccessful details call.
  • Authorization notification.

Fixes

@raoulritter raoulritter requested a review from a team as a code owner July 2, 2024 11:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

@RokPopov RokPopov RokPopov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raoulritter @khushboo-singhvi @RokPopov