Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove StyleProps type to eliminate code duplication #1800

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ashrafchowdury
Copy link
Contributor

Description:
Refactored the codebase by removing all the StyleProps types, which is currently leading to code duplication.

Changes:

  1. Declared a StyleProps type in the Types.ts file.
  2. Imported the StyleProps type wherever it is used.

Copy link

vercel bot commented Jun 18, 2024

@ashrafchowdury is attempting to deploy a commit to the mmabrouk's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Frontend refactoring typescript labels Jun 18, 2024
@aakrem aakrem requested a review from bekossy June 23, 2024 17:41
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ashrafchowdury

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend lgtm This PR has been approved by a maintainer refactoring size:M This PR changes 30-99 lines, ignoring generated files. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants